Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15994002: Move more browser-specific webkit/fileapi code to webkit/browser/fileapi (Closed)

Created:
7 years, 7 months ago by kinuko
Modified:
7 years, 7 months ago
CC:
chromium-reviews, vsevik, nkostylev+watch_chromium.org, tfarina, jam, yurys, joi+watch-content_chromium.org, Aaron Boodman, rginda+watch_chromium.org, jochen+watch_chromium.org, darin-cc_chromium.org, pfeldman, oshima+watch_chromium.org, tzik+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move more browser-specific webkit/fileapi code to webkit/browser/fileapi Moves following files (25 files, 55/130 -> 80/130): - external_mount_points* - file_observers.h - file_system_task_runners* - isolated_context* - isolated_mount_point_provider* - local_file_system_operation* - mock_* - mount_points* - task_runner_bound_observer_list.h BUG=239710 TBR=tzik@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202079

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -6310 lines) Patch
M chrome/browser/chromeos/drive/drive_integration_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system_util_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/drive_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/external_filesystem_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_handler_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_file_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/device_media_async_file_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_system_mount_point_provider.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/mtp_device_map_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/picasa/picasa_file_util_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/media_galleries/imported_media_gallery_registry.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/media_file_system_registry.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/scoped_mtp_device_map_entry.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/pepper/pepper_crx_file_system_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_metadata_store_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/child_process_security_policy_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/browser_file_system_helper.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/fileapi/fileapi_message_filter.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 1 3 chunks +8 lines, -8 lines 0 comments Download
M content/shell/shell_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/blob/blob_url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/copy_or_move_file_validator_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/cross_operation_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/browser/fileapi/external_mount_points.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + webkit/browser/fileapi/external_mount_points.cc View 2 chunks +3 lines, -2 lines 0 comments Download
A + webkit/browser/fileapi/external_mount_points_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/browser/fileapi/file_observers.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/file_system_dir_url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_mount_point_provider_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/file_system_quota_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_quota_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/browser/fileapi/file_system_task_runners.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/browser/fileapi/file_system_task_runners.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_url_request_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/browser/fileapi/isolated_context.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + webkit/browser/fileapi/isolated_context.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/browser/fileapi/isolated_context_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/isolated_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/isolated_file_util_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + webkit/browser/fileapi/isolated_mount_point_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/browser/fileapi/isolated_mount_point_provider.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + webkit/browser/fileapi/local_file_system_cross_operation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/browser/fileapi/local_file_system_operation.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/browser/fileapi/local_file_system_operation.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/browser/fileapi/local_file_system_operation_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + webkit/browser/fileapi/local_file_system_operation_write_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/local_file_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/browser/fileapi/mock_file_change_observer.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + webkit/browser/fileapi/mock_file_change_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/browser/fileapi/mock_file_system_context.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/browser/fileapi/mock_file_system_context.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + webkit/browser/fileapi/mock_file_system_options.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/browser/fileapi/mock_file_system_options.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/browser/fileapi/mount_points.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/browser/fileapi/mount_points.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util_unittest.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/browser/fileapi/recursive_operation_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_file_stream_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_file_stream_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_mount_point_provider.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_mount_point_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/sandbox_mount_point_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_quota_observer.h View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/browser/fileapi/task_runner_bound_observer_list.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/transient_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/transient_file_util_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/webkit_browser_fileapi.gypi View 1 3 chunks +14 lines, -0 lines 0 comments Download
M webkit/chromeos/fileapi/cros_mount_point_provider.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/chromeos/fileapi/cros_mount_point_provider_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D webkit/fileapi/external_mount_points.h View 1 chunk +0 lines, -169 lines 0 comments Download
D webkit/fileapi/external_mount_points.cc View 1 chunk +0 lines, -358 lines 0 comments Download
D webkit/fileapi/external_mount_points_unittest.cc View 1 chunk +0 lines, -462 lines 0 comments Download
D webkit/fileapi/file_observers.h View 1 chunk +0 lines, -83 lines 0 comments Download
M webkit/fileapi/file_system_context.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/file_system_context.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M webkit/fileapi/file_system_context_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/fileapi/file_system_file_stream_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/file_system_file_stream_reader_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/fileapi/file_system_operation_context.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/file_system_operation_context.cc View 1 chunk +1 line, -1 line 0 comments Download
D webkit/fileapi/file_system_task_runners.h View 1 chunk +0 lines, -55 lines 0 comments Download
D webkit/fileapi/file_system_task_runners.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M webkit/fileapi/file_system_url.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/fileapi/file_system_url_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/fileapi/file_writer_delegate_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D webkit/fileapi/isolated_context.h View 1 chunk +0 lines, -197 lines 0 comments Download
D webkit/fileapi/isolated_context.cc View 1 chunk +0 lines, -469 lines 0 comments Download
D webkit/fileapi/isolated_context_unittest.cc View 1 chunk +0 lines, -336 lines 0 comments Download
D webkit/fileapi/isolated_mount_point_provider.h View 1 chunk +0 lines, -69 lines 0 comments Download
D webkit/fileapi/isolated_mount_point_provider.cc View 1 chunk +0 lines, -176 lines 0 comments Download
D webkit/fileapi/local_file_system_cross_operation_unittest.cc View 1 chunk +0 lines, -416 lines 0 comments Download
D webkit/fileapi/local_file_system_operation.h View 1 chunk +0 lines, -341 lines 0 comments Download
D webkit/fileapi/local_file_system_operation.cc View 1 chunk +0 lines, -880 lines 0 comments Download
D webkit/fileapi/local_file_system_operation_unittest.cc View 1 1 chunk +0 lines, -1189 lines 0 comments Download
D webkit/fileapi/local_file_system_operation_write_unittest.cc View 1 chunk +0 lines, -340 lines 0 comments Download
D webkit/fileapi/mock_file_change_observer.h View 1 chunk +0 lines, -103 lines 0 comments Download
D webkit/fileapi/mock_file_change_observer.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D webkit/fileapi/mock_file_system_context.h View 1 chunk +0 lines, -25 lines 0 comments Download
D webkit/fileapi/mock_file_system_context.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D webkit/fileapi/mock_file_system_options.h View 1 chunk +0 lines, -23 lines 0 comments Download
D webkit/fileapi/mock_file_system_options.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D webkit/fileapi/mount_points.h View 1 chunk +0 lines, -106 lines 0 comments Download
D webkit/fileapi/mount_points.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M webkit/fileapi/remove_operation_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/sandbox_file_system_test_helper.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/fileapi/syncable/canned_syncable_file_system.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/fileapi/syncable/local_file_change_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/syncable/local_file_change_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/syncable/local_file_sync_context.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/fileapi/syncable/local_file_sync_context_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/syncable/syncable_file_system_operation.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/syncable/syncable_file_system_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/fileapi/syncable/syncable_file_system_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/fileapi/syncable/syncable_file_system_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D webkit/fileapi/task_runner_bound_observer_list.h View 1 chunk +0 lines, -109 lines 0 comments Download
M webkit/fileapi/test_mount_point_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/test_mount_point_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/fileapi/upload_file_system_file_element_reader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/webkit_fileapi.gypi View 1 4 chunks +0 lines, -14 lines 0 comments Download
M webkit/support/webkit_support.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/webkit_support.gypi View 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/simple_file_system.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
kinuko
PTL
7 years, 7 months ago (2013-05-24 10:39:06 UTC) #1
tzik
lgtm
7 years, 7 months ago (2013-05-24 10:57:14 UTC) #2
kinuko
TBR avi@ and thestig@ for our usual moving in content/ and chrome/. Thanks!
7 years, 7 months ago (2013-05-24 11:11:22 UTC) #3
kinuko
Committed patchset #2 manually as r202079 (presubmit successful).
7 years, 7 months ago (2013-05-24 13:58:18 UTC) #4
Avi (use Gerrit)
lgtm Yep.
7 years, 7 months ago (2013-05-24 14:36:52 UTC) #5
Lei Zhang
7 years, 7 months ago (2013-05-24 20:10:01 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698