Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: webkit/fileapi/external_mount_points_unittest.cc

Issue 15994002: Move more browser-specific webkit/fileapi code to webkit/browser/fileapi (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/fileapi/external_mount_points.cc ('k') | webkit/fileapi/file_observers.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "webkit/fileapi/external_mount_points.h"
6
7 #include <string>
8
9 #include "base/files/file_path.h"
10 #include "testing/gtest/include/gtest/gtest.h"
11 #include "webkit/fileapi/file_system_url.h"
12
13 #define FPL FILE_PATH_LITERAL
14
15 #if defined(FILE_PATH_USES_DRIVE_LETTERS)
16 #define DRIVE FPL("C:")
17 #else
18 #define DRIVE
19 #endif
20
21 using fileapi::FileSystemURL;
22
23 namespace {
24
25 TEST(ExternalMountPointsTest, AddMountPoint) {
26 scoped_refptr<fileapi::ExternalMountPoints> mount_points(
27 fileapi::ExternalMountPoints::CreateRefCounted());
28
29 struct TestCase {
30 // The mount point's name.
31 const char* const name;
32 // The mount point's path.
33 const base::FilePath::CharType* const path;
34 // Whether the mount point registration should succeed.
35 bool success;
36 // Path returned by GetRegisteredPath. NULL if the method is expected to
37 // fail.
38 const base::FilePath::CharType* const registered_path;
39 };
40
41 const TestCase kTestCases[] = {
42 // Valid mount point.
43 { "test", DRIVE FPL("/foo/test"), true, DRIVE FPL("/foo/test") },
44 // Valid mount point with only one path component.
45 { "bbb", DRIVE FPL("/bbb"), true, DRIVE FPL("/bbb") },
46 // Existing mount point path is substring of the mount points path.
47 { "test11", DRIVE FPL("/foo/test11"), true, DRIVE FPL("/foo/test11") },
48 // Path substring of an existing path.
49 { "test1", DRIVE FPL("/foo/test1"), true, DRIVE FPL("/foo/test1") },
50 // Empty mount point name and path.
51 { "", DRIVE FPL(""), false, NULL },
52 // Empty mount point name.
53 { "", DRIVE FPL("/ddd"), false, NULL },
54 // Empty mount point path.
55 { "empty_path", FPL(""), true, FPL("") },
56 // Name different from path's base name.
57 { "not_base_name", DRIVE FPL("/x/y/z"), true, DRIVE FPL("/x/y/z") },
58 // References parent.
59 { "invalid", DRIVE FPL("../foo/invalid"), false, NULL },
60 // Relative path.
61 { "relative", DRIVE FPL("foo/relative"), false, NULL },
62 // Existing mount point path.
63 { "path_exists", DRIVE FPL("/foo/test"), false, NULL },
64 // Mount point with the same name exists.
65 { "test", DRIVE FPL("/foo/a/test_name_exists"), false,
66 DRIVE FPL("/foo/test") },
67 // Child of an existing mount point.
68 { "a1", DRIVE FPL("/foo/test/a"), false, NULL },
69 // Parent of an existing mount point.
70 { "foo1", DRIVE FPL("/foo"), false, NULL },
71 // Bit bigger depth.
72 { "g", DRIVE FPL("/foo/a/b/c/d/e/f/g"), true,
73 DRIVE FPL("/foo/a/b/c/d/e/f/g") },
74 // Sibling mount point (with similar name) exists.
75 { "ff", DRIVE FPL("/foo/a/b/c/d/e/ff"), true,
76 DRIVE FPL("/foo/a/b/c/d/e/ff") },
77 // Lexicographically last among existing mount points.
78 { "yyy", DRIVE FPL("/zzz/yyy"), true, DRIVE FPL("/zzz/yyy") },
79 // Parent of the lexicographically last mount point.
80 { "zzz1", DRIVE FPL("/zzz"), false, NULL },
81 // Child of the lexicographically last mount point.
82 { "xxx1", DRIVE FPL("/zzz/yyy/xxx"), false, NULL },
83 // Lexicographically first among existing mount points.
84 { "b", DRIVE FPL("/a/b"), true, DRIVE FPL("/a/b") },
85 // Parent of lexicographically first mount point.
86 { "a2", DRIVE FPL("/a"), false, NULL },
87 // Child of lexicographically last mount point.
88 { "c1", DRIVE FPL("/a/b/c"), false, NULL },
89 // Parent to all of the mount points.
90 { "root", DRIVE FPL("/"), false, NULL },
91 // Path contains .. component.
92 { "funky", DRIVE FPL("/tt/fun/../funky"), false, NULL },
93 // Windows separators.
94 #if defined(FILE_PATH_USES_WIN_SEPARATORS)
95 { "win", DRIVE FPL("\\try\\separators\\win"), true,
96 DRIVE FPL("\\try\\separators\\win") },
97 { "win1", DRIVE FPL("\\try/separators\\win1"), true,
98 DRIVE FPL("\\try/separators\\win1") },
99 { "win2", DRIVE FPL("\\try/separators\\win"), false, NULL },
100 #else
101 { "win", DRIVE FPL("\\separators\\win"), false, NULL },
102 { "win1", DRIVE FPL("\\try/separators\\win1"), false, NULL },
103 #endif
104 // Win separators, but relative path.
105 { "win2", DRIVE FPL("try\\separators\\win2"), false, NULL },
106 };
107
108 // Test adding mount points.
109 for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kTestCases); ++i) {
110 EXPECT_EQ(kTestCases[i].success,
111 mount_points->RegisterFileSystem(
112 kTestCases[i].name,
113 fileapi::kFileSystemTypeNativeLocal,
114 base::FilePath(kTestCases[i].path)))
115 << "Adding mount point: " << kTestCases[i].name << " with path "
116 << kTestCases[i].path;
117 }
118
119 // Test that final mount point presence state is as expected.
120 for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kTestCases); ++i) {
121 base::FilePath found_path;
122 EXPECT_EQ(kTestCases[i].registered_path != NULL,
123 mount_points->GetRegisteredPath(kTestCases[i].name, &found_path))
124 << "Test case: " << i;
125
126 if (kTestCases[i].registered_path) {
127 base::FilePath expected_path(kTestCases[i].registered_path);
128 EXPECT_EQ(expected_path.NormalizePathSeparators(), found_path);
129 }
130 }
131 }
132
133 TEST(ExternalMountPointsTest, GetVirtualPath) {
134 scoped_refptr<fileapi::ExternalMountPoints> mount_points(
135 fileapi::ExternalMountPoints::CreateRefCounted());
136
137 mount_points->RegisterFileSystem("c",
138 fileapi::kFileSystemTypeNativeLocal,
139 base::FilePath(DRIVE FPL("/a/b/c")));
140 // Note that "/a/b/c" < "/a/b/c(1)" < "/a/b/c/".
141 mount_points->RegisterFileSystem("c(1)",
142 fileapi::kFileSystemTypeNativeLocal,
143 base::FilePath(DRIVE FPL("/a/b/c(1)")));
144 mount_points->RegisterFileSystem("x",
145 fileapi::kFileSystemTypeNativeLocal,
146 base::FilePath(DRIVE FPL("/z/y/x")));
147 mount_points->RegisterFileSystem("o",
148 fileapi::kFileSystemTypeNativeLocal,
149 base::FilePath(DRIVE FPL("/m/n/o")));
150 // A mount point whose name does not match its path base name.
151 mount_points->RegisterFileSystem("mount",
152 fileapi::kFileSystemTypeNativeLocal,
153 base::FilePath(DRIVE FPL("/root/foo")));
154 // A mount point with an empty path.
155 mount_points->RegisterFileSystem("empty_path",
156 fileapi::kFileSystemTypeNativeLocal,
157 base::FilePath());
158
159 struct TestCase {
160 const base::FilePath::CharType* const local_path;
161 bool success;
162 const base::FilePath::CharType* const virtual_path;
163 };
164
165 const TestCase kTestCases[] = {
166 // Empty path.
167 { FPL(""), false, FPL("") },
168 // No registered mount point (but is parent to a mount point).
169 { DRIVE FPL("/a/b"), false, FPL("") },
170 // No registered mount point (but is parent to a mount point).
171 { DRIVE FPL("/z/y"), false, FPL("") },
172 // No registered mount point (but is parent to a mount point).
173 { DRIVE FPL("/m/n"), false, FPL("") },
174 // No registered mount point.
175 { DRIVE FPL("/foo/mount"), false, FPL("") },
176 // An existing mount point path is substring.
177 { DRIVE FPL("/a/b/c1"), false, FPL("") },
178 // No leading /.
179 { DRIVE FPL("a/b/c"), false, FPL("") },
180 // Sibling to a root path.
181 { DRIVE FPL("/a/b/d/e"), false, FPL("") },
182 // Sibling to a root path.
183 { DRIVE FPL("/z/y/v/u"), false, FPL("") },
184 // Sibling to a root path.
185 { DRIVE FPL("/m/n/p/q"), false, FPL("") },
186 // Mount point root path.
187 { DRIVE FPL("/a/b/c"), true, FPL("c") },
188 // Mount point root path.
189 { DRIVE FPL("/z/y/x"), true, FPL("x") },
190 // Mount point root path.
191 { DRIVE FPL("/m/n/o"), true, FPL("o") },
192 // Mount point child path.
193 { DRIVE FPL("/a/b/c/d/e"), true, FPL("c/d/e") },
194 // Mount point child path.
195 { DRIVE FPL("/z/y/x/v/u"), true, FPL("x/v/u") },
196 // Mount point child path.
197 { DRIVE FPL("/m/n/o/p/q"), true, FPL("o/p/q") },
198 // Name doesn't match mount point path base name.
199 { DRIVE FPL("/root/foo/a/b/c"), true, FPL("mount/a/b/c") },
200 { DRIVE FPL("/root/foo"), true, FPL("mount") },
201 // Mount point contains character whose ASCII code is smaller than file path
202 // separator's.
203 { DRIVE FPL("/a/b/c(1)/d/e"), true, FPL("c(1)/d/e") },
204 #if defined(FILE_PATH_USES_WIN_SEPARATORS)
205 // Path with win separators mixed in.
206 { DRIVE FPL("/a\\b\\c/d"), true, FPL("c/d") },
207 #endif
208 };
209
210 for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kTestCases); ++i) {
211 // Initialize virtual path with a value.
212 base::FilePath virtual_path(DRIVE FPL("/mount"));
213 base::FilePath local_path(kTestCases[i].local_path);
214 EXPECT_EQ(kTestCases[i].success,
215 mount_points->GetVirtualPath(local_path, &virtual_path))
216 << "Resolving " << kTestCases[i].local_path;
217
218 // There are no guarantees for |virtual_path| value if |GetVirtualPath|
219 // fails.
220 if (!kTestCases[i].success)
221 continue;
222
223 base::FilePath expected_virtual_path(kTestCases[i].virtual_path);
224 EXPECT_EQ(expected_virtual_path.NormalizePathSeparators(), virtual_path)
225 << "Resolving " << kTestCases[i].local_path;
226 }
227 }
228
229 TEST(ExternalMountPointsTest, HandlesFileSystemMountType) {
230 scoped_refptr<fileapi::ExternalMountPoints> mount_points(
231 fileapi::ExternalMountPoints::CreateRefCounted());
232
233 const GURL test_origin("http://chromium.org");
234 const base::FilePath test_path(FPL("/mount"));
235
236 // Should handle External File System.
237 EXPECT_TRUE(mount_points->HandlesFileSystemMountType(
238 fileapi::kFileSystemTypeExternal));
239
240 // Shouldn't handle the rest.
241 EXPECT_FALSE(mount_points->HandlesFileSystemMountType(
242 fileapi::kFileSystemTypeIsolated));
243 EXPECT_FALSE(mount_points->HandlesFileSystemMountType(
244 fileapi::kFileSystemTypeTemporary));
245 EXPECT_FALSE(mount_points->HandlesFileSystemMountType(
246 fileapi::kFileSystemTypePersistent));
247 EXPECT_FALSE(mount_points->HandlesFileSystemMountType(
248 fileapi::kFileSystemTypeTest));
249 // Not even if it's external subtype.
250 EXPECT_FALSE(mount_points->HandlesFileSystemMountType(
251 fileapi::kFileSystemTypeNativeLocal));
252 EXPECT_FALSE(mount_points->HandlesFileSystemMountType(
253 fileapi::kFileSystemTypeRestrictedNativeLocal));
254 EXPECT_FALSE(mount_points->HandlesFileSystemMountType(
255 fileapi::kFileSystemTypeDrive));
256 EXPECT_FALSE(mount_points->HandlesFileSystemMountType(
257 fileapi::kFileSystemTypeSyncable));
258 }
259
260 TEST(ExternalMountPointsTest, CreateCrackedFileSystemURL) {
261 scoped_refptr<fileapi::ExternalMountPoints> mount_points(
262 fileapi::ExternalMountPoints::CreateRefCounted());
263
264 const GURL kTestOrigin("http://chromium.org");
265
266 mount_points->RegisterFileSystem("c",
267 fileapi::kFileSystemTypeNativeLocal,
268 base::FilePath(DRIVE FPL("/a/b/c")));
269 mount_points->RegisterFileSystem("c(1)",
270 fileapi::kFileSystemTypeDrive,
271 base::FilePath(DRIVE FPL("/a/b/c(1)")));
272 mount_points->RegisterFileSystem("empty_path",
273 fileapi::kFileSystemTypeSyncable,
274 base::FilePath());
275 mount_points->RegisterFileSystem("mount",
276 fileapi::kFileSystemTypeDrive,
277 base::FilePath(DRIVE FPL("/root")));
278
279 // Try cracking invalid GURL.
280 FileSystemURL invalid = mount_points->CrackURL(GURL("http://chromium.og"));
281 EXPECT_FALSE(invalid.is_valid());
282
283 // Try cracking isolated path.
284 FileSystemURL isolated = mount_points->CreateCrackedFileSystemURL(
285 kTestOrigin, fileapi::kFileSystemTypeIsolated, base::FilePath(FPL("c")));
286 EXPECT_FALSE(isolated.is_valid());
287
288 // Try native local which is not cracked.
289 FileSystemURL native_local = mount_points->CreateCrackedFileSystemURL(
290 kTestOrigin, fileapi::kFileSystemTypeNativeLocal, base::FilePath(FPL("c")) );
291 EXPECT_FALSE(native_local.is_valid());
292
293 struct TestCase {
294 const base::FilePath::CharType* const path;
295 bool expect_valid;
296 fileapi::FileSystemType expect_type;
297 const base::FilePath::CharType* const expect_path;
298 const char* const expect_fs_id;
299 };
300
301 const TestCase kTestCases[] = {
302 { FPL("c/d/e"),
303 true, fileapi::kFileSystemTypeNativeLocal, DRIVE FPL("/a/b/c/d/e"), "c" },
304 { FPL("c(1)/d/e"),
305 true, fileapi::kFileSystemTypeDrive, DRIVE FPL("/a/b/c(1)/d/e"), "c(1)" },
306 { FPL("c(1)"),
307 true, fileapi::kFileSystemTypeDrive, DRIVE FPL("/a/b/c(1)"), "c(1)" },
308 { FPL("empty_path/a"),
309 true, fileapi::kFileSystemTypeSyncable, FPL("a"), "empty_path" },
310 { FPL("empty_path"),
311 true, fileapi::kFileSystemTypeSyncable, FPL(""), "empty_path" },
312 { FPL("mount/a/b"),
313 true, fileapi::kFileSystemTypeDrive, DRIVE FPL("/root/a/b"), "mount" },
314 { FPL("mount"),
315 true, fileapi::kFileSystemTypeDrive, DRIVE FPL("/root"), "mount" },
316 { FPL("cc"),
317 false, fileapi::kFileSystemTypeUnknown, FPL(""), "" },
318 { FPL(""),
319 false, fileapi::kFileSystemTypeUnknown, FPL(""), "" },
320 { FPL(".."),
321 false, fileapi::kFileSystemTypeUnknown, FPL(""), "" },
322 // Absolte paths.
323 { FPL("/c/d/e"),
324 false, fileapi::kFileSystemTypeUnknown, FPL(""), "" },
325 { FPL("/c(1)/d/e"),
326 false, fileapi::kFileSystemTypeUnknown, FPL(""), "" },
327 { FPL("/empty_path"),
328 false, fileapi::kFileSystemTypeUnknown, FPL(""), "" },
329 // PAth references parent.
330 { FPL("c/d/../e"),
331 false, fileapi::kFileSystemTypeUnknown, FPL(""), "" },
332 { FPL("/empty_path/a/../b"),
333 false, fileapi::kFileSystemTypeUnknown, FPL(""), "" },
334 #if defined(FILE_PATH_USES_WIN_SEPARATORS)
335 { FPL("c/d\\e"),
336 true, fileapi::kFileSystemTypeNativeLocal, DRIVE FPL("/a/b/c/d/e"), "c" },
337 { FPL("mount\\a\\b"),
338 true, fileapi::kFileSystemTypeDrive, DRIVE FPL("/root/a/b"), "mount" },
339 #endif
340 };
341
342 for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kTestCases); ++i) {
343 FileSystemURL cracked = mount_points->CreateCrackedFileSystemURL(
344 kTestOrigin,
345 fileapi::kFileSystemTypeExternal,
346 base::FilePath(kTestCases[i].path));
347
348 EXPECT_EQ(kTestCases[i].expect_valid, cracked.is_valid())
349 << "Test case index: " << i;
350
351 if (!kTestCases[i].expect_valid)
352 continue;
353
354 EXPECT_EQ(kTestOrigin, cracked.origin())
355 << "Test case index: " << i;
356 EXPECT_EQ(kTestCases[i].expect_type, cracked.type())
357 << "Test case index: " << i;
358 EXPECT_EQ(base::FilePath(kTestCases[i].expect_path).NormalizePathSeparators( ),
359 cracked.path())
360 << "Test case index: " << i;
361 EXPECT_EQ(base::FilePath(kTestCases[i].path).NormalizePathSeparators(),
362 cracked.virtual_path())
363 << "Test case index: " << i;
364 EXPECT_EQ(kTestCases[i].expect_fs_id, cracked.filesystem_id())
365 << "Test case index: " << i;
366 EXPECT_EQ(fileapi::kFileSystemTypeExternal, cracked.mount_type())
367 << "Test case index: " << i;
368 }
369 }
370
371 TEST(ExternalMountPointsTest, CrackVirtualPath) {
372 scoped_refptr<fileapi::ExternalMountPoints> mount_points(
373 fileapi::ExternalMountPoints::CreateRefCounted());
374
375 const GURL kTestOrigin("http://chromium.org");
376
377 mount_points->RegisterFileSystem("c",
378 fileapi::kFileSystemTypeNativeLocal,
379 base::FilePath(DRIVE FPL("/a/b/c")));
380 mount_points->RegisterFileSystem("c(1)",
381 fileapi::kFileSystemTypeDrive,
382 base::FilePath(DRIVE FPL("/a/b/c(1)")));
383 mount_points->RegisterFileSystem("empty_path",
384 fileapi::kFileSystemTypeSyncable,
385 base::FilePath());
386 mount_points->RegisterFileSystem("mount",
387 fileapi::kFileSystemTypeDrive,
388 base::FilePath(DRIVE FPL("/root")));
389
390 struct TestCase {
391 const base::FilePath::CharType* const path;
392 bool expect_valid;
393 fileapi::FileSystemType expect_type;
394 const base::FilePath::CharType* const expect_path;
395 const char* const expect_name;
396 };
397
398 const TestCase kTestCases[] = {
399 { FPL("c/d/e"),
400 true, fileapi::kFileSystemTypeNativeLocal, DRIVE FPL("/a/b/c/d/e"), "c" },
401 { FPL("c(1)/d/e"),
402 true, fileapi::kFileSystemTypeDrive, DRIVE FPL("/a/b/c(1)/d/e"), "c(1)" },
403 { FPL("c(1)"),
404 true, fileapi::kFileSystemTypeDrive, DRIVE FPL("/a/b/c(1)"), "c(1)" },
405 { FPL("empty_path/a"),
406 true, fileapi::kFileSystemTypeSyncable, FPL("a"), "empty_path" },
407 { FPL("empty_path"),
408 true, fileapi::kFileSystemTypeSyncable, FPL(""), "empty_path" },
409 { FPL("mount/a/b"),
410 true, fileapi::kFileSystemTypeDrive, DRIVE FPL("/root/a/b"), "mount" },
411 { FPL("mount"),
412 true, fileapi::kFileSystemTypeDrive, DRIVE FPL("/root"), "mount" },
413 { FPL("cc"),
414 false, fileapi::kFileSystemTypeUnknown, FPL(""), "" },
415 { FPL(""),
416 false, fileapi::kFileSystemTypeUnknown, FPL(""), "" },
417 { FPL(".."),
418 false, fileapi::kFileSystemTypeUnknown, FPL(""), "" },
419 // Absolte paths.
420 { FPL("/c/d/e"),
421 false, fileapi::kFileSystemTypeUnknown, FPL(""), "" },
422 { FPL("/c(1)/d/e"),
423 false, fileapi::kFileSystemTypeUnknown, FPL(""), "" },
424 { FPL("/empty_path"),
425 false, fileapi::kFileSystemTypeUnknown, FPL(""), "" },
426 // PAth references parent.
427 { FPL("c/d/../e"),
428 false, fileapi::kFileSystemTypeUnknown, FPL(""), "" },
429 { FPL("/empty_path/a/../b"),
430 false, fileapi::kFileSystemTypeUnknown, FPL(""), "" },
431 #if defined(FILE_PATH_USES_WIN_SEPARATORS)
432 { FPL("c/d\\e"),
433 true, fileapi::kFileSystemTypeNativeLocal, DRIVE FPL("/a/b/c/d/e"), "c" },
434 { FPL("mount\\a\\b"),
435 true, fileapi::kFileSystemTypeDrive, DRIVE FPL("/root/a/b"), "mount" },
436 #endif
437 };
438
439 for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kTestCases); ++i) {
440 std::string cracked_name;
441 fileapi::FileSystemType cracked_type;
442 base::FilePath cracked_path;
443 EXPECT_EQ(kTestCases[i].expect_valid,
444 mount_points->CrackVirtualPath(base::FilePath(kTestCases[i].path),
445 &cracked_name, &cracked_type, &cracked_path))
446 << "Test case index: " << i;
447
448 if (!kTestCases[i].expect_valid)
449 continue;
450
451 EXPECT_EQ(kTestCases[i].expect_type, cracked_type)
452 << "Test case index: " << i;
453 EXPECT_EQ(base::FilePath(kTestCases[i].expect_path).NormalizePathSeparators( ),
454 cracked_path)
455 << "Test case index: " << i;
456 EXPECT_EQ(kTestCases[i].expect_name, cracked_name)
457 << "Test case index: " << i;
458 }
459 }
460
461 } // namespace
462
OLDNEW
« no previous file with comments | « webkit/fileapi/external_mount_points.cc ('k') | webkit/fileapi/file_observers.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698