Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 15993016: Remove the optimized construct stub. (Closed)

Created:
7 years, 6 months ago by Toon Verwaest
Modified:
7 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix 64bit #

Total comments: 6

Patch Set 3 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1210 lines) Patch
M src/arm/stub-cache-arm.cc View 1 chunk +0 lines, -145 lines 0 comments Download
M src/ast.h View 8 chunks +7 lines, -23 lines 0 comments Download
M src/compiler.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M src/heap.cc View 1 2 4 chunks +0 lines, -58 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 chunk +0 lines, -139 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 1 chunk +0 lines, -151 lines 0 comments Download
M src/objects.h View 1 2 7 chunks +4 lines, -43 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -108 lines 0 comments Download
M src/objects-inl.h View 1 4 chunks +3 lines, -14 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/parser.h View 2 chunks +0 lines, -19 lines 0 comments Download
M src/parser.cc View 10 chunks +0 lines, -205 lines 0 comments Download
M src/runtime.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/stub-cache.h View 1 chunk +0 lines, -11 lines 0 comments Download
M src/stub-cache.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 chunk +0 lines, -133 lines 0 comments Download
D test/mjsunit/bugs/618.js View 1 chunk +0 lines, -86 lines 0 comments Download
D test/mjsunit/bugs/bug-618.js View 1 chunk +0 lines, -45 lines 0 comments Download
M test/mjsunit/object-define-property.js View 1 chunk +9 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-618.js View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL
7 years, 6 months ago (2013-06-04 16:42:38 UTC) #1
Michael Starzinger
LGTM with two nits and one real comments in the objects.h file. Code-b-gone! https://codereview.chromium.org/15993016/diff/3001/src/heap.cc File ...
7 years, 6 months ago (2013-06-05 08:34:04 UTC) #2
Toon Verwaest
Addressed comments https://codereview.chromium.org/15993016/diff/3001/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/15993016/diff/3001/src/heap.cc#newcode4201 src/heap.cc:4201: ASSERT(in_object_properties <= Map::kMaxPreAllocatedPropertyFields); On 2013/06/05 08:34:04, Michael ...
7 years, 6 months ago (2013-06-05 08:41:42 UTC) #3
Toon Verwaest
7 years, 6 months ago (2013-06-05 08:43:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r14946 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698