Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issue 1599143002: Remove CertCacheTrial (DiskBasedCertCache). (Closed)

Created:
4 years, 11 months ago by martijnc
Modified:
4 years, 11 months ago
CC:
asvitkine+watch_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, gavinp+disk_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove CertCacheTrial (DiskBasedCertCache). Removes CertCacheTrial related code that was added in: https://codereview.chromium.org/329733002 https://codereview.chromium.org/356953003 BUG=522312 Committed: https://crrev.com/f9f21c101b486ff42c813fe48971c9909fac6a8e Cr-Commit-Position: refs/heads/master@{#371313}

Patch Set 1 #

Patch Set 2 : crbug.com doesn't like trailing slashes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1436 lines) Patch
D net/http/disk_based_cert_cache.h View 1 chunk +0 lines, -106 lines 0 comments Download
D net/http/disk_based_cert_cache.cc View 1 chunk +0 lines, -598 lines 0 comments Download
D net/http/disk_based_cert_cache_unittest.cc View 1 chunk +0 lines, -535 lines 0 comments Download
M net/http/http_cache.h View 3 chunks +0 lines, -5 lines 0 comments Download
M net/http/http_cache.cc View 4 chunks +0 lines, -13 lines 0 comments Download
M net/http/http_cache_transaction.h View 1 chunk +0 lines, -5 lines 0 comments Download
M net/http/http_cache_transaction.cc View 5 chunks +0 lines, -171 lines 0 comments Download
M net/net.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 8 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
martijnc
This is all the CertCacheTrial related code I could find. Can you take a look? ...
4 years, 11 months ago (2016-01-18 21:26:33 UTC) #3
mmenke
I don't know this code. [+rsleevi]: Ryan, you commented on the bug. Can you review, ...
4 years, 11 months ago (2016-01-19 05:33:12 UTC) #5
Ryan Sleevi
On 2016/01/19 05:33:12, mmenke wrote: > I don't know this code. > > [+rsleevi]: Ryan, ...
4 years, 11 months ago (2016-01-19 19:20:55 UTC) #6
Ryan Sleevi
Sorry it took a bit longer than I expected. This LGTM. One thing I was ...
4 years, 11 months ago (2016-01-22 23:57:36 UTC) #7
martijnc
Thank you for taking a look. +isherman: Can you review the histogram.xml changes?
4 years, 11 months ago (2016-01-23 12:26:03 UTC) #9
Ilya Sherman
histograms.xml lgtm -- thanks!
4 years, 11 months ago (2016-01-25 19:36:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1599143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1599143002/20001
4 years, 11 months ago (2016-01-25 19:38:57 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-25 21:11:12 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 21:12:40 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f9f21c101b486ff42c813fe48971c9909fac6a8e
Cr-Commit-Position: refs/heads/master@{#371313}

Powered by Google App Engine
This is Rietveld 408576698