Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1492)

Unified Diff: net/http/http_cache.cc

Issue 1599143002: Remove CertCacheTrial (DiskBasedCertCache). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: crbug.com doesn't like trailing slashes Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_cache.h ('k') | net/http/http_cache_transaction.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_cache.cc
diff --git a/net/http/http_cache.cc b/net/http/http_cache.cc
index ae678fd2f8bda4bc4e4702530bd9271058bf0383..f572c14f56968b846720d4b05ce2cfd1c107fe28 100644
--- a/net/http/http_cache.cc
+++ b/net/http/http_cache.cc
@@ -34,7 +34,6 @@
#include "net/base/net_errors.h"
#include "net/base/upload_data_stream.h"
#include "net/disk_cache/disk_cache.h"
-#include "net/http/disk_based_cert_cache.h"
#include "net/http/disk_cache_based_quic_server_info.h"
#include "net/http/http_cache_transaction.h"
#include "net/http/http_network_layer.h"
@@ -49,15 +48,6 @@
#include <unistd.h>
#endif
-namespace {
-
-bool UseCertCache() {
- return base::FieldTrialList::FindFullName("CertCacheTrial") ==
- "ExperimentGroup";
-}
-
-} // namespace
-
namespace net {
HttpCache::DefaultBackend::DefaultBackend(
@@ -354,7 +344,6 @@ HttpCache::~HttpCache() {
// Before deleting pending_ops_, we have to make sure that the disk cache is
// done with said operations, or it will attempt to use deleted data.
- cert_cache_.reset();
disk_cache_.reset();
PendingOpsMap::iterator pending_it = pending_ops_.begin();
@@ -1144,8 +1133,6 @@ void HttpCache::OnBackendCreated(int result, PendingOp* pending_op) {
backend_factory_.reset(); // Reclaim memory.
if (result == OK) {
disk_cache_ = std::move(pending_op->backend);
- if (UseCertCache())
- cert_cache_.reset(new DiskBasedCertCache(disk_cache_.get()));
}
}
« no previous file with comments | « net/http/http_cache.h ('k') | net/http/http_cache_transaction.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698