Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 159903004: Revert of Revert "Revert of Update of change event for input type number (Closed)

Created:
6 years, 10 months ago by tkent
Modified:
6 years, 10 months ago
Reviewers:
Habib Virji, keishi
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Visibility:
Public.

Description

Revert of Revert "Revert of Update of change event for input type number (https://codereview.chromium.org/128… (https://codereview.chromium.org/142963002/) Reason for revert: INPUT element dispatches extra events. Original issue's description: > Revert "Revert of Update of change event for input type number (https://codereview.chromium.org/128133002/)" > > The revert didn't help. > > Original issue's description: > > Revert of Update of change event for input type number (https://codereview.chromium.org/128133002/) > > > > Reason for revert: > > I'm afraid It made time-multiple-fields-spinbutton-change-and-input-events.html flaky. > > > > > > Original issue's description: > > > Do not dispatch 'change' events during pressing spin buttons for input[type=number]. > > > > > > TextFieldInputType sends change event for its derived class. Change is > > > done for DispatchInputAndChangeEvent to behave similar to > > > DispatchChangeEvent. > > > DispatchChangeEvent is generated by Range, Radio, File and Checkbox > > > input type. > > > DispatchInputAndChangeEvent is generated by inputtype for step up and > > > down, BaseChooser/BaseMultipleFieldsDateandTime also generates > > > DispatchInputAndChangeEvent. > > > Since it is different set of inputs that generate DispatchChange and > > > DispatchInputAndChange, both are kept but behavior is changed; this > > > allows spin button to handle mouseup event. > > > Keyboard events are also handled for spin button. > > > > > > R=tkent > > > BUG=155747 > > > TEST=automated > > > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165300 > > > > TBR=keishi@chromium.org,habib.virji@samsung.com > > NOTREECHECKS=true > > NOTRY=true > > BUG=155747 > > TBR=keishi@chromium.org,habib.virji@samsung.com > NOTREECHECKS=true > NOTRY=true > BUG=155747 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165377 TBR=habib.virji@samsung.com,keishi@chromium.org NOTREECHECKS=true NOTRY=true BUG=155747

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -68 lines) Patch
D LayoutTests/fast/forms/number/number-spinbutton-changeevent-trigger.html View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/fast/forms/number/number-spinbutton-changeevent-trigger-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M LayoutTests/fast/forms/number/number-type-update-by-change-event.html View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/forms/InputType.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/forms/TextFieldInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/TextFieldInputType.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/html/shadow/SpinButtonElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/shadow/SpinButtonElement.cpp View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tkent
Created Revert of Revert "Revert of Update of change event for input type number (https://codereview.chromium.org/128…
6 years, 10 months ago (2014-02-12 07:39:59 UTC) #1
commit-bot: I haz the power
6 years, 10 months ago (2014-02-12 07:40:10 UTC) #2
The CQ bit was unchecked by commit-bot@chromium.org

Powered by Google App Engine
This is Rietveld 408576698