DescriptionRevert of Revert "Revert of Update of change event for input type number (https://codereview.chromium.org/128… (https://codereview.chromium.org/142963002/)
Reason for revert:
INPUT element dispatches extra events.
Original issue's description:
> Revert "Revert of Update of change event for input type number (https://codereview.chromium.org/128133002/)"
>
> The revert didn't help.
>
> Original issue's description:
> > Revert of Update of change event for input type number (https://codereview.chromium.org/128133002/)
> >
> > Reason for revert:
> > I'm afraid It made time-multiple-fields-spinbutton-change-and-input-events.html flaky.
> >
> >
> > Original issue's description:
> > > Do not dispatch 'change' events during pressing spin buttons for input[type=number].
> > >
> > > TextFieldInputType sends change event for its derived class. Change is
> > > done for DispatchInputAndChangeEvent to behave similar to
> > > DispatchChangeEvent.
> > > DispatchChangeEvent is generated by Range, Radio, File and Checkbox
> > > input type.
> > > DispatchInputAndChangeEvent is generated by inputtype for step up and
> > > down, BaseChooser/BaseMultipleFieldsDateandTime also generates
> > > DispatchInputAndChangeEvent.
> > > Since it is different set of inputs that generate DispatchChange and
> > > DispatchInputAndChange, both are kept but behavior is changed; this
> > > allows spin button to handle mouseup event.
> > > Keyboard events are also handled for spin button.
> > >
> > > R=tkent
> > > BUG=155747
> > > TEST=automated
> > >
> > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165300
> >
> > TBR=keishi@chromium.org,habib.virji@samsung.com
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=155747
>
> TBR=keishi@chromium.org,habib.virji@samsung.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=155747
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165377
TBR=habib.virji@samsung.com,keishi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=155747
Patch Set 1 #
Created: 6 years, 10 months ago
(Patch set is too large to download)
Messages
Total messages: 2 (0 generated)
|