Issue 15990009: Call abort() if NSS cannot read from /dev/urandom.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15990009: Call abort() if NSS cannot read from /dev/urandom. (Closed)

Created:
7 years, 6 months ago by wtc

Modified:
7 years, 6 months ago

Reviewers:
Ryan Sleevi

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/nss/

Visibility:
Public.

More Reviews

Description

Call abort() if NSS cannot read from /dev/urandom. R=rsleevi@chromium.org BUG=244661 TEST=content_unittests --gtest_filter=MacSandboxTest.NSSAccess

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove the stat change #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -1 line)			Patch
M	README.chromium	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	nss/lib/freebl/unix_rand.c	View	1	2 chunks	+19 lines, -1 line	0 comments	Download
A	patches/nss-urandom-abort.patch	View	1	1 chunk	+38 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

wtc

The final version of this CL will depend on the outcome of https://codereview.chromium.org/16748002/ https://codereview.chromium.org/15990009/diff/1/nss/lib/freebl/unix_rand.c File ...

7 years, 6 months ago (2013-06-10 19:39:37 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/15990009/4001

7 years, 6 months ago (2013-06-10 21:47:03 UTC) #3

Message was sent while issue was closed.

Change committed as 205313

Expand Messages | Collapse Messages