sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart - Issue 15988003: Fix issue 9228, by nopt doing some optimizations in checked mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart

Issue 15988003: Fix issue 9228, by nopt doing some optimizations in checked mode. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart ('k') | tests/co19/co19-dart2js.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart (revision 23244)

+++ sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart (working copy)

@@ -197,7 +197,11 @@

if (instruction.specializer is BinaryArithmeticSpecializer) {

HInstruction left = instruction.inputs[1];

HInstruction right = instruction.inputs[2];

- if (left.isNumber() && !right.isNumber()) {

+ if (left.isNumber()

+ && !right.isNumber()

+ // We need to call the actual method in checked mode to get

+ // the right type error.

+ && !compiler.enableTypeAssertions) {

pendingOptimizations[instruction] = () {

// This callback function is invoked after we're done

// propagating types. The types shouldn't have changed.

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart ('k') | tests/co19/co19-dart2js.status » ('j') | no next file with comments »