sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart - Issue 15988003: Fix issue 9228, by nopt doing some optimizations in checked mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart

Issue 15988003: Fix issue 9228, by nopt doing some optimizations in checked mode. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/codegen.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart (revision 23244)

+++ sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart (working copy)

@@ -100,6 +100,10 @@

HInstruction tryConvertToBuiltin(HInvokeDynamic instruction,

Compiler compiler) {

if (instruction.inputs[1].isMutableIndexable(compiler)) {

+ if (!instruction.inputs[2].isInteger() && compiler.enableTypeAssertions) {

+ // We want the right checked mode error.

+ return null;

+ }

return new HIndexAssign(instruction.inputs[1],

instruction.inputs[2],

instruction.inputs[3],

@@ -130,6 +134,10 @@

HInstruction tryConvertToBuiltin(HInvokeDynamic instruction,

Compiler compiler) {

if (instruction.inputs[1].isIndexable(compiler)) {

+ if (!instruction.inputs[2].isInteger() && compiler.enableTypeAssertions) {

+ // We want the right checked mode error.

+ return null;

+ }

HInstruction index = new HIndex(

instruction.inputs[1], instruction.inputs[2], instruction.selector);

index.instructionType =