Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: chrome/browser/extensions/extension_function_dispatcher.cc

Issue 15987009: Update chrome/ to use WeakPtr<T>::get() instead of implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_function_dispatcher.cc
diff --git a/chrome/browser/extensions/extension_function_dispatcher.cc b/chrome/browser/extensions/extension_function_dispatcher.cc
index a7b352430bfccc2f18722bf044d2061e29f8076e..204eca710cab1589bf5786e4af4b0304f2fc5687 100644
--- a/chrome/browser/extensions/extension_function_dispatcher.cc
+++ b/chrome/browser/extensions/extension_function_dispatcher.cc
@@ -149,11 +149,16 @@ void IOThreadResponseCallback(
ExtensionFunction::ResponseType type,
const base::ListValue& results,
const std::string& error) {
- if (!ipc_sender)
+ if (!ipc_sender.get())
return;
- CommonResponseCallback(ipc_sender, routing_id, ipc_sender->peer_handle(),
- request_id, type, results, error);
+ CommonResponseCallback(ipc_sender.get(),
+ routing_id,
+ ipc_sender->peer_handle(),
+ request_id,
+ type,
+ results,
+ error);
}
} // namespace
@@ -176,9 +181,9 @@ class ExtensionFunctionDispatcher::UIThreadResponseCallbackWrapper
virtual void RenderViewHostDestroyed(
RenderViewHost* render_view_host) OVERRIDE {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- if (dispatcher_) {
- dispatcher_->ui_thread_response_callback_wrappers_.erase(
- render_view_host);
+ if (dispatcher_.get()) {
+ dispatcher_->ui_thread_response_callback_wrappers_
+ .erase(render_view_host);
}
// This call will delete |this|.
« no previous file with comments | « chrome/browser/extensions/extension_disabled_ui.cc ('k') | chrome/browser/extensions/external_install_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698