Translate: Filter and record languages whose names Chrome doesn't show

Translate: Filter and record languages whose names Chrome doesn't show

1) Filter undisplayable languages (, whose names Chrome doesn't show)
2) Record undisplayable languages
3) Rename TranslateManagerMetrics to TranslateBrowserMetrics
4) Obsolete Translate.ServerReportedUnsupportedLanguage

The Tranlate server sends the language list, and this may include a language UI can't deal with for lack of the resource.  This CL filters such languages and reports them by UMA 'Translate.UndisplayableLanguage'.  This UMA can be substitute of 'Translate.ServerReportedUnsupportedLanguage'.  'Translate.ServerReportedUnsupportedLanguage' is no longer needed and I made it obsolete.

Originally, we intended to implement the other UMA 'Translate.UnavailableLanguage' https://chromiumcodereview.appspot.com/15311006/, but changed our direction.

Moreover, Translate.ServerReportedUnsupportedLanguage was supposed to be removed in that CL, but I kept it unchanged accidentally.

BUG=242142
TEST=unit_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206371

[hajimehoshi, 2013-05-30 05:35:50]

Could you take a look?

[Takashi Toyoshima, 2013-05-30 06:04:31]

lgtm with one request.

https://codereview.chromium.org/15987004/diff/1/chrome/browser/translate/tran...
File chrome/browser/translate/translate_language_list.cc (right):

https://codereview.chromium.org/15987004/diff/1/chrome/browser/translate/tran...
chrome/browser/translate/translate_language_list.cc:16: #include
"chrome/browser/translate/translate_manager_metrics.h"
now that we use it out of TranslateManager, let's rename it to
translate_browser_metrics or something.

[hajimehoshi, 2013-05-30 06:44:56]

Thanks! (sorry but I rebased it at the same time as fixing it.)

https://chromiumcodereview.appspot.com/15987004/diff/1/chrome/browser/transla...
File chrome/browser/translate/translate_language_list.cc (right):

https://chromiumcodereview.appspot.com/15987004/diff/1/chrome/browser/transla...
chrome/browser/translate/translate_language_list.cc:16: #include
"chrome/browser/translate/translate_manager_metrics.h"
On 2013/05/30 06:04:31, Takashi Toyoshima (chromium) wrote:
> now that we use it out of TranslateManager, let's rename it to
> translate_browser_metrics or something.

Done.

[Takashi Toyoshima, 2013-05-30 06:54:11]

still lgtm.
Thanks!

[Ilya Sherman, 2013-06-01 00:59:47]

LGTM with nits:

https://codereview.chromium.org/15987004/diff/7001/chrome/browser/translate/t...
File chrome/browser/translate/translate_browser_metrics.cc (right):

https://codereview.chromium.org/15987004/diff/7001/chrome/browser/translate/t...
chrome/browser/translate/translate_browser_metrics.cc:25:
"Translate.UndisplayableLanguage";
nit: Alphabetize?

https://codereview.chromium.org/15987004/diff/7001/tools/metrics/histograms/h...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/15987004/diff/7001/tools/metrics/histograms/h...
tools/metrics/histograms/histograms.xml:9430: Deprecated 5/2013 by
Translate.Unsu
Looks like the text got cut off mid-word.

https://codereview.chromium.org/15987004/diff/7001/tools/metrics/histograms/h...
tools/metrics/histograms/histograms.xml:9482: Logs an undisplayable language are
included in the language list sent by the
nit: "Logs an undisplayable language are included" -> "Logs an undisplayable
language included"

https://codereview.chromium.org/15987004/diff/7001/tools/metrics/histograms/h...
tools/metrics/histograms/histograms.xml:9484: runs Chrome. This metrics tells us
that there is a language which UI should
nit: "which UI should deal with" -> "which the UI should support"

[hajimehoshi, 2013-06-05 04:44:05]

Thanks!

https://codereview.chromium.org/15987004/diff/7001/chrome/browser/translate/t...
File chrome/browser/translate/translate_browser_metrics.cc (right):

https://codereview.chromium.org/15987004/diff/7001/chrome/browser/translate/t...
chrome/browser/translate/translate_browser_metrics.cc:25:
"Translate.UndisplayableLanguage";
On 2013/06/01 00:59:47, Ilya Sherman wrote:
> nit: Alphabetize?

Done.

https://codereview.chromium.org/15987004/diff/7001/tools/metrics/histograms/h...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/15987004/diff/7001/tools/metrics/histograms/h...
tools/metrics/histograms/histograms.xml:9430: Deprecated 5/2013 by
Translate.Unsu
On 2013/06/01 00:59:47, Ilya Sherman wrote:
> Looks like the text got cut off mid-word.

Done.

https://codereview.chromium.org/15987004/diff/7001/tools/metrics/histograms/h...
tools/metrics/histograms/histograms.xml:9482: Logs an undisplayable language are
included in the language list sent by the
On 2013/06/01 00:59:47, Ilya Sherman wrote:
> nit: "Logs an undisplayable language are included" -> "Logs an undisplayable
> language included"

Done.

https://codereview.chromium.org/15987004/diff/7001/tools/metrics/histograms/h...
tools/metrics/histograms/histograms.xml:9484: runs Chrome. This metrics tells us
that there is a language which UI should
On 2013/06/01 00:59:47, Ilya Sherman wrote:
> nit: "which UI should deal with" -> "which the UI should support"

Done.

[hajimehoshi, 2013-06-05 05:05:21]

+tony, can you take a look at ui/base/l10n/*?  Thank you in advance.

On 2013/06/05 04:44:05, hajimehoshi wrote:
> Thanks!
> 
>
https://codereview.chromium.org/15987004/diff/7001/chrome/browser/translate/t...
> File chrome/browser/translate/translate_browser_metrics.cc (right):
> 
>
https://codereview.chromium.org/15987004/diff/7001/chrome/browser/translate/t...
> chrome/browser/translate/translate_browser_metrics.cc:25:
> "Translate.UndisplayableLanguage";
> On 2013/06/01 00:59:47, Ilya Sherman wrote:
> > nit: Alphabetize?
> 
> Done.
> 
>
https://codereview.chromium.org/15987004/diff/7001/tools/metrics/histograms/h...
> File tools/metrics/histograms/histograms.xml (right):
> 
>
https://codereview.chromium.org/15987004/diff/7001/tools/metrics/histograms/h...
> tools/metrics/histograms/histograms.xml:9430: Deprecated 5/2013 by
> Translate.Unsu
> On 2013/06/01 00:59:47, Ilya Sherman wrote:
> > Looks like the text got cut off mid-word.
> 
> Done.
> 
>
https://codereview.chromium.org/15987004/diff/7001/tools/metrics/histograms/h...
> tools/metrics/histograms/histograms.xml:9482: Logs an undisplayable language
are
> included in the language list sent by the
> On 2013/06/01 00:59:47, Ilya Sherman wrote:
> > nit: "Logs an undisplayable language are included" -> "Logs an undisplayable
> > language included"
> 
> Done.
> 
>
https://codereview.chromium.org/15987004/diff/7001/tools/metrics/histograms/h...
> tools/metrics/histograms/histograms.xml:9484: runs Chrome. This metrics tells
us
> that there is a language which UI should
> On 2013/06/01 00:59:47, Ilya Sherman wrote:
> > nit: "which UI should deal with" -> "which the UI should support"
> 
> Done.

[jungshik at Google, 2013-06-07 22:37:38]

What do you mean by 'undisplayable languages'? 

The APi you use is for finding out whether the ICU data has the full locale data
or just nominal locale data (the display name of the language in its own
language, writing direction, the character repertoire required for writing in
that language).  

It has very little to do with a language in question being displayable or not.

[hajimehoshi, 2013-06-10 04:39:42]

For example, Haitian (ht) on the Vietnamese (vi) locale.  ICU
(third_party/icu/source/data/lang/vi.txt) doesn't define 'ht'.  Even though 'ht'
is supported by Translate server, the client on the Vietnamese locale can't show
this language's name properly.  This CL checks such this language.  Are there
any other ways to perform this?

On 2013/06/07 22:37:38, Jungshik Shin wrote:
> What do you mean by 'undisplayable languages'? 
> 
> The APi you use is for finding out whether the ICU data has the full locale
data
> or just nominal locale data (the display name of the language in its own
> language, writing direction, the character repertoire required for writing in
> that language).  
> 
> It has very little to do with a language in question being displayable or not.

[hajimehoshi, 2013-06-10 06:34:47]

I modified the description in an understandable way.

On 2013/06/10 04:39:42, hajimehoshi wrote:
> For example, Haitian (ht) on the Vietnamese (vi) locale.  ICU
> (third_party/icu/source/data/lang/vi.txt) doesn't define 'ht'.  Even though
'ht'
> is supported by Translate server, the client on the Vietnamese locale can't
show
> this language's name properly.  This CL checks such this language.  Are there
> any other ways to perform this?
> 
> On 2013/06/07 22:37:38, Jungshik Shin wrote:
> > What do you mean by 'undisplayable languages'? 
> > 
> > The APi you use is for finding out whether the ICU data has the full locale
> data
> > or just nominal locale data (the display name of the language in its own
> > language, writing direction, the character repertoire required for writing
in
> > that language).  
> > 
> > It has very little to do with a language in question being displayable or
not.

[hajimehoshi, 2013-06-13 02:59:26]

ping

On 2013/06/10 06:34:47, hajimehoshi wrote:
> I modified the description in an understandable way.
> 
> On 2013/06/10 04:39:42, hajimehoshi wrote:
> > For example, Haitian (ht) on the Vietnamese (vi) locale.  ICU
> > (third_party/icu/source/data/lang/vi.txt) doesn't define 'ht'.  Even though
> 'ht'
> > is supported by Translate server, the client on the Vietnamese locale can't
> show
> > this language's name properly.  This CL checks such this language.  Are
there
> > any other ways to perform this?
> > 
> > On 2013/06/07 22:37:38, Jungshik Shin wrote:
> > > What do you mean by 'undisplayable languages'? 
> > > 
> > > The APi you use is for finding out whether the ICU data has the full
locale
> > data
> > > or just nominal locale data (the display name of the language in its own
> > > language, writing direction, the character repertoire required for writing
> in
> > > that language).  
> > > 
> > > It has very little to do with a language in question being displayable or
> not.

[jungshik at Google, 2013-06-13 05:45:00]

Thank you for the explanation. Then, it looks good to me. Sorry for the delay.

[hajimehoshi, 2013-06-13 05:48:02]

Thanks.  I'd be glad if you gave me the 'lgtm' keyword because you are an owner
of ui/base/l10n.

On 2013/06/13 05:45:00, Jungshik Shin wrote:
> Thank you for the explanation. Then, it looks good to me. Sorry for the delay.

[jungshik at Google, 2013-06-13 17:03:24]

LGTM (I thought 'looks good to me' would be picked up as well. :-)
On 2013/06/13 05:48:02, hajimehoshi wrote:
> Thanks.  I'd be glad if you gave me the 'lgtm' keyword because you are an
owner
> of ui/base/l10n.
> 
> On 2013/06/13 05:45:00, Jungshik Shin wrote:
> > Thank you for the explanation. Then, it looks good to me. Sorry for the
delay.

[commit-bot: I haz the power, 2013-06-14 03:06:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/15987004/68001

[commit-bot: I haz the power, 2013-06-14 05:16:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/15987004/87001

[commit-bot: I haz the power, 2013-06-14 08:39:42]

Change committed as 206371