Translate: Filter and record languages whose names Chrome doesn't show

chrome/browser/translate/translate_browser_metrics.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/browser/translate/translate_manager_metrics.h"
+#include "chrome/browser/translate/translate_browser_metrics.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/metrics/histogram.h"
 #include "base/metrics/sparse_histogram.h"
 #include "chrome/browser/language_usage_metrics.h"
 
 namespace {
 
 // Constant string values to indicate UMA names. All entries should have
 // a corresponding index in MetricsNameIndex and an entry in |kMetricsEntries|.
 const char kTranslateInitiationStatus[] =
     "Translate.InitiationStatus";
 const char kTranslateReportLanguageDetectionError[] =
     "Translate.ReportLanguageDetectionError";
-const char kTranslateServerReportedUnsupportedLanguage[] =
-    "Translate.ServerReportedUnsupportedLanguage";
 const char kTranslateUnsupportedLanguageAtInitiation[] =
     "Translate.UnsupportedLanguageAtInitiation";
+const char kTranslateUndisplayableLanguage[] =
+    "Translate.UndisplayableLanguage";

[Ilya Sherman, 2013/06/01 00:59:47]

nit: Alphabetize?

[hajimehoshi, 2013/06/05 04:44:05]

Done.

 
 struct MetricsEntry {
-  TranslateManagerMetrics::MetricsNameIndex index;
+  TranslateBrowserMetrics::MetricsNameIndex index;
   const char* const name;
 };
 
 // This entry table should be updated when new UMA items are added.
 const MetricsEntry kMetricsEntries[] = {
-  { TranslateManagerMetrics::UMA_INITIATION_STATUS,
+  { TranslateBrowserMetrics::UMA_INITIATION_STATUS,
     kTranslateInitiationStatus },
-  { TranslateManagerMetrics::UMA_LANGUAGE_DETECTION_ERROR,
+  { TranslateBrowserMetrics::UMA_LANGUAGE_DETECTION_ERROR,
     kTranslateReportLanguageDetectionError },
-  { TranslateManagerMetrics::UMA_SERVER_REPORTED_UNSUPPORTED_LANGUAGE,
-    kTranslateServerReportedUnsupportedLanguage },
-  { TranslateManagerMetrics::UMA_UNSUPPORTED_LANGUAGE_AT_INITIATION,
+  { TranslateBrowserMetrics::UMA_UNSUPPORTED_LANGUAGE_AT_INITIATION,
     kTranslateUnsupportedLanguageAtInitiation },
+  { TranslateBrowserMetrics::UMA_UNDISPLAYABLE_LANGUAGE,
+    kTranslateUndisplayableLanguage },
 };
 
-COMPILE_ASSERT(arraysize(kMetricsEntries) == TranslateManagerMetrics::UMA_MAX,
+COMPILE_ASSERT(arraysize(kMetricsEntries) == TranslateBrowserMetrics::UMA_MAX,
                arraysize_of_kMetricsEntries_should_be_UMA_MAX);
 
 }  // namespace
 
-namespace TranslateManagerMetrics {
+namespace TranslateBrowserMetrics {
 
 void ReportInitiationStatus(InitiationStatusType type) {
   UMA_HISTOGRAM_ENUMERATION(kTranslateInitiationStatus,
                             type,
                             INITIATION_STATUS_MAX);
 }
 
 void ReportLanguageDetectionError() {
   UMA_HISTOGRAM_COUNTS(kTranslateReportLanguageDetectionError, 1);
 }
 
-void ReportUnsupportedLanguage() {
-  UMA_HISTOGRAM_COUNTS(kTranslateServerReportedUnsupportedLanguage, 1);
-}
-
 void ReportUnsupportedLanguageAtInitiation(const std::string& language) {
   int language_code = LanguageUsageMetrics::ToLanguageCode(language);
   UMA_HISTOGRAM_SPARSE_SLOWLY(kTranslateUnsupportedLanguageAtInitiation,
                               language_code);
 }
 
+void ReportUndisplayableLanguage(const std::string& language) {
+  int language_code = LanguageUsageMetrics::ToLanguageCode(language);
+  UMA_HISTOGRAM_SPARSE_SLOWLY(kTranslateUndisplayableLanguage,
+                              language_code);
+}
+
 const char* GetMetricsName(MetricsNameIndex index) {
   for (size_t i = 0; i < arraysize(kMetricsEntries); ++i) {
     if (kMetricsEntries[i].index == index)
       return kMetricsEntries[i].name;
   }
   NOTREACHED();
   return NULL;
 }
 
-}  // namespace TranslateManagerMetrics
+}  // namespace TranslateBrowserMetrics