A quick fix for Issue 18837 (and a build fix for VS2008)

A blind fix for Issue 18837 (and a build fix for VS2008)
To read this crash dump, this issue is caused by my mistake that this jumplist.cc calls "icon_urls_.front()" for an empty list.
This change added some checks that verifies a std::list has one or more items.
This change also fixes linker errors because of conflicted symbols: CLSID_DestinationList and CLSID_EnumerableObjectCollection, which is caused by my mistake that I forgot removing "EXTERN_C" keywords when I moved them into an anonymous namespace. This change removes the "EXTERN_C" keywords for VS2008.

BUG=18837
"Crash - JumpList::OnFavIconDataAvailable(int,bool,scoped_refptr<RefCountedVector<unsigned char> >,bool,GURL)"
TEST=Show JumpList on Windows 7.
TEST=Build Chromium with VS2008.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22907

[Ben Goodger (Google), 2009-08-10 04:22:18]

http://codereview.chromium.org/159853/diff/4003/4004
File chrome/browser/jumplist.cc (right):

http://codereview.chromium.org/159853/diff/4003/4004#newcode716
Line 716: if (icon_urls_.size() && icon_urls_.front().second)
maybe !icon_urls_.empty()?

http://codereview.chromium.org/159853/diff/4003/4004#newcode721
Line 721: if (icon_urls_.size())
ditto

[Hironori Bono, 2009-08-10 04:34:40]

Thank you for your quick review and comments. Your comments become wake-up calls
for me. :)

Regards,

Hironori Bono

http://codereview.chromium.org/159853/diff/4003/4004
File chrome/browser/jumplist.cc (right):

http://codereview.chromium.org/159853/diff/4003/4004#newcode716
Line 716: if (icon_urls_.size() && icon_urls_.front().second)
On 2009/08/10 04:22:18, Ben Goodger wrote:
> maybe !icon_urls_.empty()?

Done. Thank you for correcting my stupid mistake. :)

http://codereview.chromium.org/159853/diff/4003/4004#newcode721
Line 721: if (icon_urls_.size())
On 2009/08/10 04:22:18, Ben Goodger wrote:
> ditto

Done. Thank you again.

[Ben Goodger (Google), 2009-08-10 04:35:38]

LGTM.