A quick fix for Issue 18837 (and a build fix for VS2008)

chrome/browser/jumplist.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/jumplist.h"
 
 #include <windows.h>
 #include <shobjidl.h>
 #include <propkey.h>
 #include <propvarutil.h>
@@ skipping 91 matching lines @@
       /* [in] */ __RPC__in REFIID riid,
       /* [iid_is][out] */ __RPC__deref_out_opt void **ppv) = 0;
   virtual HRESULT STDMETHODCALLTYPE DeleteList(
       /* [string][in] */ __RPC__in_string LPCWSTR pszAppID) = 0;
   virtual HRESULT STDMETHODCALLTYPE AbortList(void) = 0;
 };
 
 #endif  // __ICustomDestinationList_INTERFACE_DEFINED__
 
 // Class IDs used in this file.
-// These class IDs should be defined in an anonymous namespace to avoid
-// potential conflicts with ones defined in "shell32.lib" of Microsoft SDK 7.0.
+// These class IDs must be defined in an anonymous namespace to avoid
+// conflicts with ones defined in "shell32.lib" of Visual Studio 2008.
 // TODO(hbono): Bug 16903: to be deleted them when we use Windows SDK 7.0.
-EXTERN_C const CLSID CLSID_DestinationList = {
+const CLSID CLSID_DestinationList = {
   0x77f10cf0, 0x3db5, 0x4966, {0xb5, 0x20, 0xb7, 0xc5, 0x4f, 0xd3, 0x5e, 0xd6}
 };
 
-EXTERN_C const CLSID CLSID_EnumerableObjectCollection = {
+const CLSID CLSID_EnumerableObjectCollection = {
   0x2d3468c1, 0x36a7, 0x43b6, {0xac, 0x24, 0xd3, 0xf0, 0x2f, 0xd9, 0x60, 0x7a}
 };
 
 };  // namespace
 
 // END OF WINDOWS 7 SDK DEFINITIONS
 
 namespace {
 
 // Represents a class which encapsulates a PROPVARIANT object containing a
@@ skipping 575 matching lines @@
 }
 
 void JumpList::OnFavIconDataAvailable(
     HistoryService::Handle handle,
     bool know_favicon,
     scoped_refptr<RefCountedBytes> data,
     bool expired,
     GURL icon_url) {
   // Attach the received data to the ShellLinkItem object.
   // This data will be decoded by JumpListUpdateTask.
-  if (know_favicon && data.get() && !data->data.empty())
-    icon_urls_.front().second->SetIconData(data);
+  if (know_favicon && data.get() && !data->data.empty()) {
+    if (!icon_urls_.empty() && icon_urls_.front().second)
+      icon_urls_.front().second->SetIconData(data);
+  }
 
   // if we need to load more fav icons, we send another query and exit.
-  icon_urls_.pop_front();
+  if (!icon_urls_.empty())
+    icon_urls_.pop_front();
   if (StartLoadingFavIcon())
     return;
 
   // Finished Loading all fav icons needed by the application JumpList.
   // We create a JumpListUpdateTask that creates icon files, and we post it to
   // the file thread.
   Task* icon_task = new JumpListUpdateTask(icon_dir_,
                                            most_visited_pages_,
                                            recently_closed_pages_);
   MessageLoop* file_loop = g_browser_process->file_thread()->message_loop();
   if (file_loop)
     file_loop->PostTask(FROM_HERE, icon_task);
 
   // Delete all items in these lists since we don't need these lists any longer.
   most_visited_pages_.clear();
   recently_closed_pages_.clear();
 }