Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Unified Diff: chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_helper_unittest.cc ('k') | chrome/browser/ui/tabs/tab_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc
diff --git a/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc b/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc
index 32a49eac33544a4cd6f390be8fb5f4fd0d68116f..465995d41b67ca4a2b986ae3190f80c6e9ffdea5 100644
--- a/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc
+++ b/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc
@@ -203,8 +203,7 @@ TEST_F(ProfileSigninConfirmationHelperTest, PromptForNewProfile_Extensions) {
scoped_refptr<extensions::Extension> webstore =
CreateExtension("web store", extension_misc::kWebStoreAppId);
extensions->extension_prefs()->AddGrantedPermissions(
- webstore->id(),
- make_scoped_refptr(new extensions::PermissionSet));
+ webstore->id(), make_scoped_refptr(new extensions::PermissionSet).get());
extensions->AddExtension(webstore.get());
EXPECT_FALSE(GetCallbackResult(
base::Bind(&ui::CheckShouldPromptForNewProfile, profile_.get())));
@@ -212,7 +211,7 @@ TEST_F(ProfileSigninConfirmationHelperTest, PromptForNewProfile_Extensions) {
scoped_refptr<extensions::Extension> extension =
CreateExtension("foo", std::string());
extensions->extension_prefs()->AddGrantedPermissions(
- extension->id(), make_scoped_refptr(new extensions::PermissionSet));
+ extension->id(), make_scoped_refptr(new extensions::PermissionSet).get());
extensions->AddExtension(extension.get());
EXPECT_TRUE(GetCallbackResult(
base::Bind(&ui::CheckShouldPromptForNewProfile, profile_.get())));
« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_helper_unittest.cc ('k') | chrome/browser/ui/tabs/tab_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698