Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 159836: linux: improve warnings when NSS/PR shutdowns fail (Closed)

Created:
11 years, 4 months ago by Evan Martin
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

linux: improve warnings when NSS/PR shutdowns fail Make one into a LOG(INFO) since it's relatively harmless; add comments on the other with a link to the bug. BUG=4609, 18410

Patch Set 1 #

Total comments: 3

Patch Set 2 : retry #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M base/nss_init.cc View 1 1 chunk +12 lines, -5 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
Evan Martin
11 years, 4 months ago (2009-08-04 00:44:30 UTC) #1
Evan Martin
+willchan in case he has thoughts
11 years, 4 months ago (2009-08-04 00:45:43 UTC) #2
wtc
"They always fail" in the description of this CL is misleading. It is possible to ...
11 years, 4 months ago (2009-08-04 00:48:31 UTC) #3
Evan Martin
On 2009/08/04 00:48:31, wtc wrote: > "They always fail" in the description of this CL ...
11 years, 4 months ago (2009-08-04 00:50:44 UTC) #4
wtc
evan: I added two comments to Patch Set 1, but I got a "500 Server ...
11 years, 4 months ago (2009-08-04 17:21:20 UTC) #5
Evan Martin
http://codereview.chromium.org/159836/diff/1/2 File base/nss_init.cc (right): http://codereview.chromium.org/159836/diff/1/2#newcode137 Line 137: PR_Cleanup(); On 2009/08/04 17:18:56, wtc wrote: > PR_Cleanup ...
11 years, 4 months ago (2009-08-04 17:29:52 UTC) #6
Evan Martin
ok, new patch up
11 years, 4 months ago (2009-08-04 17:34:42 UTC) #7
wtc
11 years, 4 months ago (2009-08-04 17:42:19 UTC) #8
LGTM.  Thanks!

Could you use the shorter http://crbug.com/xxx URLs in comments?

http://codereview.chromium.org/159836/diff/1005/1006
File base/nss_init.cc (right):

http://codereview.chromium.org/159836/diff/1005/1006#newcode146
Line 146: // a potential race.
Nit: "a potential race" => "NSPR isn't initialized and cleaned up on the same
thread"

Powered by Google App Engine
This is Rietveld 408576698