linux: improve warnings when NSS/PR shutdowns fail

base/nss_init.cc

Index: base/nss_init.cc
diff --git a/base/nss_init.cc b/base/nss_init.cc
index 15fad89460397d1df89d3aa751da68017bd2b52f..074b19a42bcbc518bd52bfbed1958c285e6bc1e8 100644
--- a/base/nss_init.cc
+++ b/base/nss_init.cc
@@ -131,15 +131,22 @@ class NSSInitSingleton {
     SSL_ClearSessionCache();
 
     SECStatus status = NSS_Shutdown();
-    if (status != SECSuccess)
-      LOG(ERROR) << "NSS_Shutdown failed, leak?  See "
-                    "http://code.google.com/p/chromium/issues/detail?id=4609";
+    if (status != SECSuccess) {
+      // We LOG(INFO) because this failure is relatively harmless
+      // (leaking, but we're shutting down anyway).
+      LOG(INFO) << "NSS_Shutdown failed; see "
+                   "http://code.google.com/p/chromium/issues/detail?id=4609";
+    }
 
     PL_ArenaFinish();
 
     PRStatus prstatus = PR_Cleanup();
-    if (prstatus != PR_SUCCESS)
-      LOG(ERROR) << "PR_Cleanup failed?";
+    if (prstatus != PR_SUCCESS) {
+      // We LOG(ERROR) here because this failure is bad: it indicates
+      // a potential race.

[wtc, 2009/08/04 17:42:21]

Nit: "a potential race" => "NSPR isn't initialized and cleaned up on the same
thread"

+      LOG(ERROR) << "PR_Cleanup failed; see "
+                    "http://code.google.com/p/chromium/issues/detail?id=18410";
+    }
   }
 
  private: