Add support for GetHomeDir for Mac and Windows.

Add support for GetHomeDir for Mac and Windows.

Unifies the Path Service's base::DIR_HOME on Posix and base::DIR_PROFILE on Windows to just be base::DIR_HOME everywhere, and DIR_HOME will now work on Mac.

This removes the AssertIOAllowed check in the Posix implementation because that was only executed in a fallback case that no developer is likely to ever hit. In addition, the we do call this type of function on the UI thread, so either we need to promote the assertion to be at the top of the function or delete it. It seemed unreasonable to disallow using this one key of the path service on the UI thread (the other ones are OK) so I just went for deleting the assertion.

R=benwells@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252066

[brettw, 2014-02-14 23:34:26]

ping?

[benwells, 2014-02-16 23:39:50]

Sorry for not seeing this soon :-/

https://codereview.chromium.org/159833003/diff/540001/base/base_paths.cc
File base/base_paths.cc (left):

https://codereview.chromium.org/159833003/diff/540001/base/base_paths.cc#oldc...
base/base_paths.cc:39: default:
Nit: I thought google style was to handle the default case.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Loops_...

https://codereview.chromium.org/159833003/diff/540001/base/file_util_mac.mm
File base/file_util_mac.mm (right):

https://codereview.chromium.org/159833003/diff/540001/base/file_util_mac.mm#n...
base/file_util_mac.mm:35: FilePath GetHomeDir() {
You should also remove the handling for base::DIR_HOME from base_paths_mac.mm so
this improved version is used.

https://codereview.chromium.org/159833003/diff/540001/base/file_util_mac.mm#n...
base/file_util_mac.mm:36: const char* home_dir = getenv("HOME");
I don't know much about mac. Is the change to prioritize $HOME over
NSHomeDirectory deliberate?

[brettw, 2014-02-18 19:24:42]

New snap up, thanks.

https://codereview.chromium.org/159833003/diff/540001/base/base_paths.cc
File base/base_paths.cc (left):

https://codereview.chromium.org/159833003/diff/540001/base/base_paths.cc#oldc...
base/base_paths.cc:39: default:
Oh, OK. I was just making this match the other file but default sounds good.

https://codereview.chromium.org/159833003/diff/540001/base/file_util_mac.mm
File base/file_util_mac.mm (right):

https://codereview.chromium.org/159833003/diff/540001/base/file_util_mac.mm#n...
base/file_util_mac.mm:35: FilePath GetHomeDir() {
Good catch.

https://codereview.chromium.org/159833003/diff/540001/base/file_util_mac.mm#n...
base/file_util_mac.mm:36: const char* home_dir = getenv("HOME");
I just copied the Linux behavior, but a Mac person now told me not to use the
env var so I removed it.

[benwells, 2014-02-18 23:14:39]

lgtm with a couple of nits

https://codereview.chromium.org/159833003/diff/790001/base/file_util_mac.mm
File base/file_util_mac.mm (right):

https://codereview.chromium.org/159833003/diff/790001/base/file_util_mac.mm#n...
base/file_util_mac.mm:38: FilePath mac_home_dir =
base::mac::NSStringToFilePath(NSHomeDirectory());
Nit: why not use tmp here instead of calling NSHomeDirectory again?

https://codereview.chromium.org/159833003/diff/790001/base/file_util_win.cc
File base/file_util_win.cc (right):

https://codereview.chromium.org/159833003/diff/790001/base/file_util_win.cc#n...
base/file_util_win.cc:266: return FilePath(result);
Nit: curlies around block as if spans multiple lines.

[brettw, 2014-02-19 20:36:42]

Committed patchset #11 manually as r252066 (presubmit successful).