Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1578)

Unified Diff: chrome/browser/extensions/api/file_system/file_system_apitest.cc

Issue 159833003: Add support for GetHomeDir for Mac and Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/file_system/file_system_api.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/file_system/file_system_apitest.cc
diff --git a/chrome/browser/extensions/api/file_system/file_system_apitest.cc b/chrome/browser/extensions/api/file_system/file_system_apitest.cc
index c878709cdb109d3b147b87b6e07b12228f9597d7..e8e1d71a1571627928601756738a7318ca7e089c 100644
--- a/chrome/browser/extensions/api/file_system/file_system_apitest.cc
+++ b/chrome/browser/extensions/api/file_system/file_system_apitest.cc
@@ -57,13 +57,7 @@ void AddSavedEntry(const base::FilePath& path_to_save,
extension->id(), "magic id", path_to_save, is_directory);
}
-#if defined(OS_WIN) || defined(OS_POSIX)
-#if defined(OS_WIN)
- const int kGraylistedPath = base::DIR_PROFILE;
-#elif defined(OS_POSIX)
- const int kGraylistedPath = base::DIR_HOME;
-#endif
-#endif
+const int kGraylistedPath = base::DIR_HOME;
} // namespace
@@ -157,12 +151,7 @@ IN_PROC_BROWSER_TEST_F(FileSystemApiTest, FileSystemApiGetDisplayPath) {
#if defined(OS_WIN) || defined(OS_POSIX)
IN_PROC_BROWSER_TEST_F(FileSystemApiTest, FileSystemApiGetDisplayPathPrettify) {
-#if defined(OS_WIN)
- int override = base::DIR_PROFILE;
-#elif defined(OS_POSIX)
- int override = base::DIR_HOME;
-#endif
- ASSERT_TRUE(PathService::OverrideAndCreateIfNeeded(override,
+ ASSERT_TRUE(PathService::OverrideAndCreateIfNeeded(base::DIR_HOME,
test_root_folder_, false));
base::FilePath test_file = test_root_folder_.AppendASCII("gold.txt");
« no previous file with comments | « chrome/browser/extensions/api/file_system/file_system_api.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698