Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1598103003: Migrate Handle.h WTF decls closer to their corresponding definitions. (Closed)

Created:
4 years, 11 months ago by sof
Modified:
4 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate Handle.h WTF decls closer to their corresponding definitions. Move some declarations in the WTF namespace out of the larger Handle.h, and near/next to where the corresponding types are declared. No change in functionality. R=haraken BUG= Committed: https://crrev.com/a082840891c286bb953a95a8f331bd5b06067a53 Cr-Commit-Position: refs/heads/master@{#369986}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -151 lines) Patch
M third_party/WebKit/Source/platform/heap/GarbageCollected.h View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Handle.h View 3 chunks +0 lines, -151 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapAllocator.h View 1 chunk +151 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1598103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1598103003/1
4 years, 11 months ago (2016-01-17 17:48:17 UTC) #2
sof
please take a look.
4 years, 11 months ago (2016-01-17 19:12:05 UTC) #4
haraken
LGTM
4 years, 11 months ago (2016-01-17 20:31:52 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-17 21:32:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1598103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1598103003/1
4 years, 11 months ago (2016-01-18 06:08:07 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-18 06:12:22 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-18 06:13:26 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a082840891c286bb953a95a8f331bd5b06067a53
Cr-Commit-Position: refs/heads/master@{#369986}

Powered by Google App Engine
This is Rietveld 408576698