Issue 15979020: Implement InstanceMirror.invoke (minified).

Issue 15979020: Implement InstanceMirror.invoke (minified). (Closed)

Created:
7 years, 6 months ago by ahe

Modified:
7 years, 6 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, ngeoffray, Johnni Winther, karlklose, erikcorry

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement InstanceMirror.invoke (minified). R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=23596

Patch Set 2 : Address review comments #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -13 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	1	5 chunks	+36 lines, -7 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart	View	1	3 chunks	+32 lines, -3 lines	0 comments	Download
A +	dart/tests/compiler/dart2js_extra/minified_mirrors_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/lib/mirrors/mirrors_test.dart	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/15979020/diff/2001/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right): https://codereview.chromium.org/15979020/diff/2001/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart#newcode1209 dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1209: return 'new $name:$requiredParameterCount:$optionalParameterCount'; Maybe share the suffix (compute ...

7 years, 6 months ago (2013-06-04 14:05:55 UTC) #2

ahe

Thank you, Kasper! https://codereview.chromium.org/15979020/diff/2001/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right): https://codereview.chromium.org/15979020/diff/2001/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart#newcode1209 dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1209: return 'new $name:$requiredParameterCount:$optionalParameterCount'; On 2013/06/04 14:05:55, ...

7 years, 6 months ago (2013-06-04 14:21:01 UTC) #3

ahe

7 years, 6 months ago (2013-06-04 14:21:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r23596 (presubmit successful).

Expand Messages | Collapse Messages