Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3796)

Unified Diff: chrome/browser/invalidation/invalidation_logger.h

Issue 159773006: [invalidations] Added table with registered objectsIds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@about_invalidations_clean
Patch Set: hacker_naming and more comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/invalidation/invalidation_logger.h
diff --git a/chrome/browser/invalidation/invalidation_logger.h b/chrome/browser/invalidation/invalidation_logger.h
index 0d80b9a2b69763c57c522b5d69275d9e6b53bcd1..1bec8fa1c1b313c20b9e646261c6ddbc4d1e56f2 100644
--- a/chrome/browser/invalidation/invalidation_logger.h
+++ b/chrome/browser/invalidation/invalidation_logger.h
@@ -5,8 +5,10 @@
#ifndef CHROME_BROWSER_INVALIDATION_INVALIDATION_LOGGER_H_
#define CHROME_BROWSER_INVALIDATION_INVALIDATION_LOGGER_H_
+#include <map>
#include "base/memory/scoped_ptr.h"
#include "base/observer_list.h"
+#include "sync/notifier/invalidation_util.h"
#include "sync/notifier/invalidator_state.h"
namespace base {
@@ -14,38 +16,56 @@ class DictionaryValue;
} // namespace base
namespace syncer {
+class InvalidationHandler;
class ObjectIdInvalidationMap;
-}
+} // namespace syncer
namespace invalidation {
+
class InvalidationLoggerObserver;
class InvalidationLogger {
public:
+ InvalidationLogger();
+ ~InvalidationLogger();
// Pass through to any registered InvalidationLoggerObservers.
// We will do local logging here too.
void OnRegistration(const base::DictionaryValue& details);
void OnUnregistration(const base::DictionaryValue& details);
void OnStateChange(const syncer::InvalidatorState& newState);
- void OnUpdateIds(const base::DictionaryValue& details);
+ void OnUpdateIds(std::map<std::string, syncer::ObjectIdSet> updatedIds);
void OnDebugMessage(const base::DictionaryValue& details);
void OnInvalidation(const syncer::ObjectIdInvalidationMap& details);
+ // Triggers messages to be sent to the Observers to provide them with
+ // the current state of the logging.
void EmitContent();
- InvalidationLogger();
- ~InvalidationLogger();
-
- void RegisterForDebug(InvalidationLoggerObserver* debug_observer);
- void UnregisterForDebug(InvalidationLoggerObserver* debug_observer);
+ // Add and remove observers listening for messages.
+ void RegisterObserver(InvalidationLoggerObserver* debug_observer);
+ void UnregisterObserver(InvalidationLoggerObserver* debug_observer);
private:
+ // Send to every Observer a OnStateChange event with the latest state.
void EmitState();
+
+ // Send to every Observer many OnUpdateIds events, each with one registrar
+ // and every objectId it currently has registered.
+ void EmitUpdatedIds();
+
// The list of every observer currently listening for notifications.
ObserverList<InvalidationLoggerObserver> observer_list_;
+
// The last InvalidatorState updated by the InvalidatorService.
syncer::InvalidatorState last_invalidator_state_;
+
+ // The map that contains every object id that is currently registered
+ // and its owner.
+ std::map<std::string, syncer::ObjectIdSet> latest_ids_;
+
+ DISALLOW_COPY_AND_ASSIGN(InvalidationLogger);
};
} // namespace invalidation
+
#endif // CHROME_BROWSER_INVALIDATION_INVALIDATION_LOGGER_H_

Powered by Google App Engine
This is Rietveld 408576698