chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.cc - Issue 159773006: [invalidations] Added table with registered objectsIds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.cc

Issue 159773006: [invalidations] Added table with registered objectsIds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@about_invalidations_clean

Patch Set: hacker_naming and more comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.h ('k') | chrome/browser/invalidation/invalidation_logger.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.cc

diff --git a/chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.cc b/chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.cc

index 1e52211bcc5ed15f6f707f0aa86a2ea941d43991..eb67f5425d076f35f858cd22802c01890a136d5a 100644

--- a/chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.cc

+++ b/chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.cc

@@ -180,6 +180,10 @@ void PushMessagingInvalidationHandler::OnIncomingInvalidation(

}

+std::string PushMessagingInvalidationHandler::GetOwnerName() const {

+ return "Push";

dcheng 2014/02/12 00:07:05 Nit: It might make things clearer in about:invalid

mferreria_g 2014/02/12 00:11:13 Done.

void PushMessagingInvalidationHandler::UpdateRegistrations() {

syncer::ObjectIdSet ids;

for (std::set<std::string>::const_iterator it =