chrome/browser/invalidation/invalidation_logger.h - Issue 159773006: [invalidations] Added table with registered objectsIds

Unified Diff: chrome/browser/invalidation/invalidation_logger.h

Issue 159773006: [invalidations] Added table with registered objectsIds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@about_invalidations_clean

Patch Set: Removed a redefinition of GetOwnerName Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.cc ('k') | chrome/browser/invalidation/invalidation_logger.cc » ('j') | chrome/browser/invalidation/invalidation_logger_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/invalidation/invalidation_logger.h

diff --git a/chrome/browser/invalidation/invalidation_logger.h b/chrome/browser/invalidation/invalidation_logger.h

index 0d80b9a2b69763c57c522b5d69275d9e6b53bcd1..0b2f6c6d1b9a4c12fdc00b5f9804c2e74b4e985d 100644

--- a/chrome/browser/invalidation/invalidation_logger.h

+++ b/chrome/browser/invalidation/invalidation_logger.h

@@ -5,8 +5,10 @@

#ifndef CHROME_BROWSER_INVALIDATION_INVALIDATION_LOGGER_H_

#define CHROME_BROWSER_INVALIDATION_INVALIDATION_LOGGER_H_

+#include <map>

#include "base/memory/scoped_ptr.h"

#include "base/observer_list.h"

+#include "sync/notifier/invalidation_util.h"

#include "sync/notifier/invalidator_state.h"

namespace base {

@@ -14,8 +16,9 @@ class DictionaryValue;

} // namespace base

namespace syncer {

+class InvalidationHandler;

class ObjectIdInvalidationMap;

+} // namespace syncer

namespace invalidation {

class InvalidationLoggerObserver;

@@ -27,7 +30,7 @@ class InvalidationLogger {

void OnRegistration(const base::DictionaryValue& details);

void OnUnregistration(const base::DictionaryValue& details);

void OnStateChange(const syncer::InvalidatorState& newState);

- void OnUpdateIds(const base::DictionaryValue& details);

+ void OnUpdateIds(std::map<std::string, syncer::ObjectIdSet> updatedIds);

void OnDebugMessage(const base::DictionaryValue& details);

void OnInvalidation(const syncer::ObjectIdInvalidationMap& details);

@@ -42,9 +45,11 @@ class InvalidationLogger {

private:

void EmitState();

// The list of every observer currently listening for notifications.

+ void EmitUpdatedIds();

Nicolas Zea 2014/02/11 21:58:25 The comment above should below this line. I'd also

mferreria_g 2014/02/12 00:03:46 Done.

ObserverList<InvalidationLoggerObserver> observer_list_;

// The last InvalidatorState updated by the InvalidatorService.

syncer::InvalidatorState last_invalidator_state_;

+ std::map<std::string, syncer::ObjectIdSet> latest_ids_;

Nicolas Zea 2014/02/11 21:58:25 add DISALLOW_COPY_AND_ASSIGN to the private member

mferreria_g 2014/02/12 00:03:46 Done.

};

} // namespace invalidation

Nicolas Zea 2014/02/11 21:58:25 nit: newline after

mferreria_g 2014/02/12 00:03:46 Done.