[invalidations] Added table with registered objectsIds

chrome/browser/invalidation/invalidation_logger.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_INVALIDATION_INVALIDATION_LOGGER_H_
 #define CHROME_BROWSER_INVALIDATION_INVALIDATION_LOGGER_H_
 
+#include <map>
 #include "base/memory/scoped_ptr.h"
 #include "base/observer_list.h"
+#include "sync/notifier/invalidation_util.h"
 #include "sync/notifier/invalidator_state.h"
 
 namespace base {
 class DictionaryValue;
 }  // namespace base
 
 namespace syncer {
+class InvalidationHandler;
 class ObjectIdInvalidationMap;
-}
+}  // namespace syncer
 
 namespace invalidation {
 class InvalidationLoggerObserver;
 
 class InvalidationLogger {
  public:
   // Pass through to any registered InvalidationLoggerObservers.
   // We will do local logging here too.
   void OnRegistration(const base::DictionaryValue& details);
   void OnUnregistration(const base::DictionaryValue& details);
   void OnStateChange(const syncer::InvalidatorState& newState);
-  void OnUpdateIds(const base::DictionaryValue& details);
+  void OnUpdateIds(std::map<std::string, syncer::ObjectIdSet> updatedIds);
   void OnDebugMessage(const base::DictionaryValue& details);
   void OnInvalidation(const syncer::ObjectIdInvalidationMap& details);
 
   void EmitContent();
 
   InvalidationLogger();

[Nicolas Zea, 2014/02/11 21:58:25]

nit: constructor/destructor should be the first methods in the class definition.

[mferreria_g, 2014/02/12 00:03:46]

Done.

   ~InvalidationLogger();
 
   void RegisterForDebug(InvalidationLoggerObserver* debug_observer);
   void UnregisterForDebug(InvalidationLoggerObserver* debug_observer);
 
  private:
   void EmitState();
   // The list of every observer currently listening for notifications.
+  void EmitUpdatedIds();

[Nicolas Zea, 2014/02/11 21:58:25]

The comment above should below this line. I'd also prefer having a comment for
this method too.

[mferreria_g, 2014/02/12 00:03:46]

Done.

   ObserverList<InvalidationLoggerObserver> observer_list_;
   // The last InvalidatorState updated by the InvalidatorService.
   syncer::InvalidatorState last_invalidator_state_;
+  std::map<std::string, syncer::ObjectIdSet> latest_ids_;

[Nicolas Zea, 2014/02/11 21:58:25]

add DISALLOW_COPY_AND_ASSIGN to the private members

[mferreria_g, 2014/02/12 00:03:46]

Done.

 };
 
 }  // namespace invalidation

[Nicolas Zea, 2014/02/11 21:58:25]

nit: newline after

[mferreria_g, 2014/02/12 00:03:46]

Done.

 #endif  // CHROME_BROWSER_INVALIDATION_INVALIDATION_LOGGER_H_