Implement V8ScriptRunner::callFunction()

Implement V8ScriptRunner::callFunction()

This patch just factors out the core part of ScriptController::callFunctionWithInstrumentation()
to V8ScriptRunner::callFunction().

The goal of the refactoring is to aggregate all call sites of Function::Call()
into V8ScriptRunner::callFunction() and V8ScriptRunner::callInternalFunction().
I'll implement V8ScriptRunner::callInternalFunction() in the next patch.

BUG=241743
R=abarth,eseidel

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151053

[haraken, 2013-05-24 04:22:32]

r?

https://codereview.chromium.org/15975002/diff/1/Source/bindings/v8/V8ScriptRu...
File Source/bindings/v8/V8ScriptRunner.cpp (right):

https://codereview.chromium.org/15975002/diff/1/Source/bindings/v8/V8ScriptRu...
Source/bindings/v8/V8ScriptRunner.cpp:143: TRACE_EVENT0("v8",
"v8.callFunction");

Previously this was:

  TRACE_EVENT1("v8", "v8.callFunction", "callsite",
resourceString(function).utf8());

I think it's OK to remove the argument for now, since it is not used in
about:tracing. (c.f. we're not adding the argument in TRACE_EVENT macros for
Script::Run().)

[abarth-chromium, 2013-05-24 06:09:22]

lgtm

[commit-bot: I haz the power, 2013-05-24 06:09:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/15975002/1

[commit-bot: I haz the power, 2013-05-24 07:01:51]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-05-24 07:14:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/15975002/1

[commit-bot: I haz the power, 2013-05-24 07:18:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/15975002/1

[commit-bot: I haz the power, 2013-05-24 07:18:53]

Failed to apply patch for Source/bindings/v8/V8ScriptRunner.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/v8/V8ScriptRunner.h
  Hunk #1 FAILED at 42.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/bindings/v8/V8ScriptRunner.h.rej

Patch:       Source/bindings/v8/V8ScriptRunner.h
Index: Source/bindings/v8/V8ScriptRunner.h
diff --git a/Source/bindings/v8/V8ScriptRunner.h
b/Source/bindings/v8/V8ScriptRunner.h
index
23a9aeced061f213710e52b68ceb7053e9726efe..2998abbf87ab39740aa80ebabfa232d1603219bf
100644
--- a/Source/bindings/v8/V8ScriptRunner.h
+++ b/Source/bindings/v8/V8ScriptRunner.h
@@ -42,6 +42,7 @@ public:
     static v8::Local<v8::Script> compileScript(v8::Handle<v8::String>, const
String&, const TextPosition&, v8::ScriptData*, v8::Isolate*);
     static v8::Local<v8::Value> runCompiledScript(v8::Handle<v8::Script>,
ScriptExecutionContext*);
     static v8::Local<v8::Value>
compileAndRunInternalScript(v8::Handle<v8::String>, v8::Isolate*,
v8::Local<v8::Context> = v8::Local<v8::Context>(), const String& = String(),
const TextPosition& = TextPosition(), v8::ScriptData* = 0);
+    static v8::Local<v8::Value> callFunction(v8::Handle<v8::Function>,
ScriptExecutionContext*, v8::Handle<v8::Object> receiver, int argc,
v8::Handle<v8::Value> args[]);
 };
 
 } // namespace WebCore

[commit-bot: I haz the power, 2013-05-24 08:06:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/15975002/15001

[commit-bot: I haz the power, 2013-05-24 08:07:18]

Change committed as 151053

[commit-bot: I haz the power, 2013-05-24 11:34:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/15975002/20001