Select when disabled should not allow value change and popup is disabled

Source/core/html/HTMLSelectElement.cpp

Index: Source/core/html/HTMLSelectElement.cpp
diff --git a/Source/core/html/HTMLSelectElement.cpp b/Source/core/html/HTMLSelectElement.cpp
index 097f90eed19660aaa225dc054ff684f1bd2821c3..585417fefee3fe7b642271b96979577027bdef4a 100644
--- a/Source/core/html/HTMLSelectElement.cpp
+++ b/Source/core/html/HTMLSelectElement.cpp
@@ -1061,8 +1061,10 @@ bool HTMLSelectElement::platformHandleKeydownEvent(KeyboardEvent* event)
             // gets called from RenderMenuList::valueChanged, which gets called
             // after the user makes a selection from the menu.
             saveLastSelection();
-            if (RenderMenuList* menuList = toRenderMenuList(renderer()))
-                menuList->showPopup();
+            if (RenderMenuList* menuList = toRenderMenuList(renderer())) {
+                if (!isDisabledOrReadOnly())

[tkent, 2014/02/17 00:14:30]

* <select> can not be read-only.

* This check has no effect.  If the SELECT element is disabled, it can't be
focused and any events are not delivered to the SELECT element.
As I already wrote, we need to close the popup when the SELECT gets disabled. 
That is to say, we need to update parseAttribute() implementation so that we can
know 'disabled' attribute change.

[Habib Virji, 2014/02/18 10:23:21]

Done.
"<select> can not be read-only."
--> Select now only checks isDisabledFormControl.
 
* "This check has no effect.  If the SELECT element is disabled, it can't be
 focused and any events are not delivered to the SELECT element."
--> That's true. But found that both event handler and attribute setting threads
are called simultaneously resulting in menuListHandler being invoked before
parseAttribute is completed. A check is added to ensure a proper disable
attribute checking before showing popup.

"As I already wrote, we need to close the popup when the SELECT gets disabled."
--> Added in parseAttribute.

"That is to say, we need to update parseAttribute() implementation so that we
can know 'disabled' attribute change."
--> Done.

+                    menuList->showPopup();
+            }
             event->setDefaultHandled();
         }
         return true;
@@ -1148,8 +1150,10 @@ void HTMLSelectElement::menuListDefaultEventHandler(Event* event)
                 // gets called from RenderMenuList::valueChanged, which gets called
                 // after the user makes a selection from the menu.
                 saveLastSelection();
-                if (RenderMenuList* menuList = toRenderMenuList(renderer()))
-                    menuList->showPopup();
+                if (RenderMenuList* menuList = toRenderMenuList(renderer())) {
+                    if (!isDisabledOrReadOnly())
+                        menuList->showPopup();
+                }
                 handled = true;
             }
         } else if (renderTheme.popsMenuByArrowKeys()) {
@@ -1166,8 +1170,10 @@ void HTMLSelectElement::menuListDefaultEventHandler(Event* event)
                 // gets called from RenderMenuList::valueChanged, which gets called
                 // after the user makes a selection from the menu.
                 saveLastSelection();
-                if (RenderMenuList* menuList = toRenderMenuList(renderer()))
-                    menuList->showPopup();
+                if (RenderMenuList* menuList = toRenderMenuList(renderer())) {
+                    if (!isDisabledOrReadOnly())
+                        menuList->showPopup();
+                }
                 handled = true;
             } else if (keyCode == '\r') {
                 if (form())
@@ -1194,7 +1200,8 @@ void HTMLSelectElement::menuListDefaultEventHandler(Event* event)
                     // which gets called after the user makes a selection from
                     // the menu.
                     saveLastSelection();
-                    menuList->showPopup();
+                    if (!isDisabledOrReadOnly())
+                        menuList->showPopup();
                 }
             }
         }