Select when disabled should not allow value change and popup is disabled

Source/core/html/HTMLSelectElement.cpp

 /*
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
@@ skipping 1043 matching lines @@
             // that our caller doesn't process the event further, but don't set
             // the event as handled.
             if (!renderer())
                 return true;
 
             // Save the selection so it can be compared to the new selection
             // when dispatching change events during selectOption, which
             // gets called from RenderMenuList::valueChanged, which gets called
             // after the user makes a selection from the menu.
             saveLastSelection();
-            if (RenderMenuList* menuList = toRenderMenuList(renderer()))
-                menuList->showPopup();
+            if (RenderMenuList* menuList = toRenderMenuList(renderer())) {
+                if (!isDisabledOrReadOnly())

[tkent, 2014/02/17 00:14:30]

* <select> can not be read-only.

* This check has no effect.  If the SELECT element is disabled, it can't be
focused and any events are not delivered to the SELECT element.
As I already wrote, we need to close the popup when the SELECT gets disabled. 
That is to say, we need to update parseAttribute() implementation so that we can
know 'disabled' attribute change.

[Habib Virji, 2014/02/18 10:23:21]

Done.
"<select> can not be read-only."
--> Select now only checks isDisabledFormControl.
 
* "This check has no effect.  If the SELECT element is disabled, it can't be
 focused and any events are not delivered to the SELECT element."
--> That's true. But found that both event handler and attribute setting threads
are called simultaneously resulting in menuListHandler being invoked before
parseAttribute is completed. A check is added to ensure a proper disable
attribute checking before showing popup.

"As I already wrote, we need to close the popup when the SELECT gets disabled."
--> Added in parseAttribute.

"That is to say, we need to update parseAttribute() implementation so that we
can know 'disabled' attribute change."
--> Done.

+                    menuList->showPopup();
+            }
             event->setDefaultHandled();
         }
         return true;
     }
 
     return false;
 }
 #endif
 
 void HTMLSelectElement::menuListDefaultEventHandler(Event* event)
@@ skipping 65 matching lines @@
                 // Calling focus() may remove the renderer or change the
                 // renderer type.
                 if (!renderer() || !renderer()->isMenuList())
                     return;
 
                 // Save the selection so it can be compared to the new selection
                 // when dispatching change events during selectOption, which
                 // gets called from RenderMenuList::valueChanged, which gets called
                 // after the user makes a selection from the menu.
                 saveLastSelection();
-                if (RenderMenuList* menuList = toRenderMenuList(renderer()))
-                    menuList->showPopup();
+                if (RenderMenuList* menuList = toRenderMenuList(renderer())) {
+                    if (!isDisabledOrReadOnly())
+                        menuList->showPopup();
+                }
                 handled = true;
             }
         } else if (renderTheme.popsMenuByArrowKeys()) {
             if (keyCode == ' ') {
                 focus();
 
                 // Calling focus() may remove the renderer or change the
                 // renderer type.
                 if (!renderer() || !renderer()->isMenuList())
                     return;
 
                 // Save the selection so it can be compared to the new selection
                 // when dispatching change events during selectOption, which
                 // gets called from RenderMenuList::valueChanged, which gets called
                 // after the user makes a selection from the menu.
                 saveLastSelection();
-                if (RenderMenuList* menuList = toRenderMenuList(renderer()))
-                    menuList->showPopup();
+                if (RenderMenuList* menuList = toRenderMenuList(renderer())) {
+                    if (!isDisabledOrReadOnly())
+                        menuList->showPopup();
+                }
                 handled = true;
             } else if (keyCode == '\r') {
                 if (form())
                     form()->submitImplicitly(event, false);
                 dispatchChangeEventForMenuList();
                 handled = true;
             }
         }
 
         if (handled)
             event->setDefaultHandled();
     }
 
     if (event->type() == EventTypeNames::mousedown && event->isMouseEvent() && toMouseEvent(event)->button() == LeftButton) {
         focus();
         if (renderer() && renderer()->isMenuList()) {
             if (RenderMenuList* menuList = toRenderMenuList(renderer())) {
                 if (menuList->popupIsVisible())
                     menuList->hidePopup();
                 else {
                     // Save the selection so it can be compared to the new
                     // selection when we call onChange during selectOption,
                     // which gets called from RenderMenuList::valueChanged,
                     // which gets called after the user makes a selection from
                     // the menu.
                     saveLastSelection();
-                    menuList->showPopup();
+                    if (!isDisabledOrReadOnly())
+                        menuList->showPopup();
                 }
             }
         }
         event->setDefaultHandled();
     }
 
     if (event->type() == EventTypeNames::blur) {
         if (RenderMenuList* menuList = toRenderMenuList(renderer())) {
             if (menuList->popupIsVisible())
                 menuList->hidePopup();
@@ skipping 352 matching lines @@
 {
     return true;
 }
 
 bool HTMLSelectElement::supportsAutofocus() const
 {
     return true;
 }
 
 } // namespace