[NaCl SDK] Remove NACL_ARCH from commom makefiles.

native_client_sdk/src/tools/nacl_gcc.mk

Index: native_client_sdk/src/tools/nacl_gcc.mk
diff --git a/native_client_sdk/src/tools/nacl_gcc.mk b/native_client_sdk/src/tools/nacl_gcc.mk
index 1460637e20f36992f45288dc7e74d2019c60caf1..f097d90164eeac4d6dbcb027ba8262b2bd72f5ed 100644
--- a/native_client_sdk/src/tools/nacl_gcc.mk
+++ b/native_client_sdk/src/tools/nacl_gcc.mk
@@ -46,15 +46,6 @@ ARM_STRIP ?= $(TC_PATH)/$(OSNAME)_arm_$(TOOLCHAIN)/bin/arm-nacl-strip
 ARM_NM ?= $(TC_PATH)/$(OSNAME)_arm_$(TOOLCHAIN)/bin/arm-nacl-nm
 
 
-# Architecture-specific flags

[binji, 2013/05/30 17:53:30]

OK, but you should either remove their use below, or add in empty definitions
here, I think.

[Sam Clegg, 2013/05/30 17:57:06]

I think it might be useful to have ARCH specific flags.

Just omitting them here is the same as having empty defs.  I'd rather omit them
in the name of keeping this file clean(er).

[binji, 2013/05/30 19:54:30]

Yes, but now it's hard to tell that they even exist -- you'd have to look in the
nasty code below to see them, and what the names are.

-X86_32_CFLAGS ?= -DNACL_ARCH=x86_32
-X86_64_CFLAGS ?= -DNACL_ARCH=x86_64
-ARM_CFLAGS ?= -DNACL_ARCH=arm
-
-X86_32_CXXFLAGS ?= -DNACL_ARCH=x86_32
-X86_64_CXXFLAGS ?= -DNACL_ARCH=x86_64
-ARM_CXXFLAGS ?= -DNACL_ARCH=arm
-
 #
 # Compile Macro
 #