[NaCl SDK] Remove NACL_ARCH from commom makefiles.

native_client_sdk/src/tools/nacl_gcc.mk

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 #
 # GNU Make based build file.  For details on GNU Make see:
 #   http://www.gnu.org/software/make/manual/make.html
 #
 #
 
@@ skipping 28 matching lines @@
 X86_64_NM ?= $(TC_PATH)/$(OSNAME)_x86_$(TOOLCHAIN)/bin/x86_64-nacl-nm
 
 ARM_CC ?= $(TC_PATH)/$(OSNAME)_arm_$(TOOLCHAIN)/bin/arm-nacl-gcc
 ARM_CXX ?= $(TC_PATH)/$(OSNAME)_arm_$(TOOLCHAIN)/bin/arm-nacl-g++
 ARM_LINK ?= $(TC_PATH)/$(OSNAME)_arm_$(TOOLCHAIN)/bin/arm-nacl-g++
 ARM_LIB ?= $(TC_PATH)/$(OSNAME)_arm_$(TOOLCHAIN)/bin/arm-nacl-ar
 ARM_STRIP ?= $(TC_PATH)/$(OSNAME)_arm_$(TOOLCHAIN)/bin/arm-nacl-strip
 ARM_NM ?= $(TC_PATH)/$(OSNAME)_arm_$(TOOLCHAIN)/bin/arm-nacl-nm
 
 
-# Architecture-specific flags

[binji, 2013/05/30 17:53:30]

OK, but you should either remove their use below, or add in empty definitions
here, I think.

[Sam Clegg, 2013/05/30 17:57:06]

I think it might be useful to have ARCH specific flags.

Just omitting them here is the same as having empty defs.  I'd rather omit them
in the name of keeping this file clean(er).

[binji, 2013/05/30 19:54:30]

Yes, but now it's hard to tell that they even exist -- you'd have to look in the
nasty code below to see them, and what the names are.

-X86_32_CFLAGS ?= -DNACL_ARCH=x86_32
-X86_64_CFLAGS ?= -DNACL_ARCH=x86_64
-ARM_CFLAGS ?= -DNACL_ARCH=arm
-
-X86_32_CXXFLAGS ?= -DNACL_ARCH=x86_32
-X86_64_CXXFLAGS ?= -DNACL_ARCH=x86_64
-ARM_CXXFLAGS ?= -DNACL_ARCH=arm
-
 #
 # Compile Macro
 #
 # $1 = Source Name
 # $2 = Compile Flags
 #
 define C_COMPILER_RULE
 -include $(call SRC_TO_DEP,$(1),_x86_32)
 $(call SRC_TO_OBJ,$(1),_x86_32): $(1) $(TOP_MAKE) | $(dir $(call SRC_TO_OBJ,$(1)))dir.stamp
         $(call LOG,CC  ,$$@,$(X86_32_CC) -o $$@ -c $$< $(POSIX_FLAGS) $(2) $(NACL_CFLAGS) $(X86_32_CFLAGS))
@@ skipping 287 matching lines @@
 ifeq ($(CONFIG),Debug)
 NMF_FLAGS += --debug-libs
 endif
 
 
 define NMF_RULE
 all:$(OUTDIR)/$(1).nmf
 $(OUTDIR)/$(1).nmf : $(foreach arch,$(NMF_ARCHES),$(OUTDIR)/$(1)$(arch)) $(GLIBC_SO_LIST)
         $(call LOG,CREATE_NMF,$$@,$(NMF) $(NMF_FLAGS) -o $$@ $$^ $(GLIBC_PATHS) -s $(OUTDIR) $(2) $(GLIBC_REMAP))
 endef