Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 15974011: [NaCl SDK] Remove NACL_ARCH from commom makefiles. (Closed)

Created:
7 years, 6 months ago by Sam Clegg
Modified:
7 years, 6 months ago
Reviewers:
binji
CC:
chromium-reviews, binji
Base URL:
http://git.chromium.org/chromium/src.git@cleanup_genhttpfs
Visibility:
Public.

Description

[NaCl SDK] Remove NACL_ARCH from commom makefiles. This macro was only used by one example, but was appearing on the compile line for all examples. Also, it can be detected more empirically at compile time using GCC's builtins. R=binji@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204582

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -14 lines) Patch
M native_client_sdk/src/examples/tutorial/dlopen/dlopen.cc View 2 chunks +10 lines, -4 lines 0 comments Download
M native_client_sdk/src/tools/host_vc.mk View 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/tools/nacl_gcc.mk View 1 2 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sam Clegg
Minor cleanup from my shuttle journey this morning... https://codereview.chromium.org/15974011/diff/2001/native_client_sdk/src/tools/host_vc.mk File native_client_sdk/src/tools/host_vc.mk (right): https://codereview.chromium.org/15974011/diff/2001/native_client_sdk/src/tools/host_vc.mk#newcode30 native_client_sdk/src/tools/host_vc.mk:30: ifeq ...
7 years, 6 months ago (2013-05-30 17:40:19 UTC) #1
binji
lgtm https://codereview.chromium.org/15974011/diff/2001/native_client_sdk/src/tools/nacl_gcc.mk File native_client_sdk/src/tools/nacl_gcc.mk (left): https://codereview.chromium.org/15974011/diff/2001/native_client_sdk/src/tools/nacl_gcc.mk#oldcode49 native_client_sdk/src/tools/nacl_gcc.mk:49: # Architecture-specific flags OK, but you should either ...
7 years, 6 months ago (2013-05-30 17:53:30 UTC) #2
Sam Clegg
https://codereview.chromium.org/15974011/diff/2001/native_client_sdk/src/tools/nacl_gcc.mk File native_client_sdk/src/tools/nacl_gcc.mk (left): https://codereview.chromium.org/15974011/diff/2001/native_client_sdk/src/tools/nacl_gcc.mk#oldcode49 native_client_sdk/src/tools/nacl_gcc.mk:49: # Architecture-specific flags On 2013/05/30 17:53:30, binji wrote: > ...
7 years, 6 months ago (2013-05-30 17:57:06 UTC) #3
binji
https://codereview.chromium.org/15974011/diff/2001/native_client_sdk/src/tools/nacl_gcc.mk File native_client_sdk/src/tools/nacl_gcc.mk (left): https://codereview.chromium.org/15974011/diff/2001/native_client_sdk/src/tools/nacl_gcc.mk#oldcode49 native_client_sdk/src/tools/nacl_gcc.mk:49: # Architecture-specific flags On 2013/05/30 17:57:06, Sam Clegg wrote: ...
7 years, 6 months ago (2013-05-30 19:54:30 UTC) #4
Sam Clegg
7 years, 6 months ago (2013-06-06 20:36:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r204582 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698