Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2517)

Unified Diff: chrome/browser/translate/translate_manager_metrics.cc

Issue 15970002: Add the new UMA key 'Translate.LocalesOnDisabledByPrefs'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_manager_metrics.cc
diff --git a/chrome/browser/translate/translate_manager_metrics.cc b/chrome/browser/translate/translate_manager_metrics.cc
index 5b11d30548b4e0b698074cad0e3ff7a83357eff0..92416b5ccc9b56e706b5c72fe614b843bcbd9ace 100644
--- a/chrome/browser/translate/translate_manager_metrics.cc
+++ b/chrome/browser/translate/translate_manager_metrics.cc
@@ -6,6 +6,8 @@
#include "base/basictypes.h"
#include "base/metrics/histogram.h"
+#include "base/metrics/sparse_histogram.h"
+#include "chrome/browser/language_usage_metrics.h"
namespace {
@@ -17,6 +19,8 @@ const char kTranslateReportLanguageDetectionError[] =
"Translate.ReportLanguageDetectionError";
const char kTranslateServerReportedUnsupportedLanguage[] =
"Translate.ServerReportedUnsupportedLanguage";
+const char kTranslateLocalesOnDisabledByPrefs[] =
+ "Translate.LocalesOnDisabledByPrefs";
struct MetricsEntry {
TranslateManagerMetrics::MetricsNameIndex index;
@@ -31,6 +35,8 @@ const MetricsEntry kMetricsEntries[] = {
kTranslateReportLanguageDetectionError },
{ TranslateManagerMetrics::UMA_SERVER_REPORTED_UNSUPPORTED_LANGUAGE,
kTranslateServerReportedUnsupportedLanguage },
+ { TranslateManagerMetrics::UMA_LOCALES_ON_DISABLED_BY_PREFS,
+ kTranslateLocalesOnDisabledByPrefs },
};
COMPILE_ASSERT(arraysize(kMetricsEntries) == TranslateManagerMetrics::UMA_MAX,
@@ -54,6 +60,11 @@ void ReportUnsupportedLanguage() {
UMA_HISTOGRAM_COUNTS(kTranslateServerReportedUnsupportedLanguage, 1);
jar (doing other things) 2013/05/24 18:06:59 Are you using this for a counter?
hajimehoshi 2013/05/27 01:13:26 This will be fixed by https://chromiumcodereview.a
}
+void ReportLocalesOnDisabledByPrefs(const std::string& locale) {
+ UMA_HISTOGRAM_SPARSE_SLOWLY(kTranslateLocalesOnDisabledByPrefs,
+ LanguageUsageMetrics::ToLanguageCode(locale));
+}
+
const char* GetMetricsName(MetricsNameIndex index) {
for (size_t i = 0; i < arraysize(kMetricsEntries); ++i) {
if (kMetricsEntries[i].index == index)

Powered by Google App Engine
This is Rietveld 408576698