Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 1596573002: Remove extra calls of didMeaningfulLayout() during the same navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index 60f33d37e6dcf04b4629364e291e821f3e2da452..71d7e7e92ae397802c94d0b652882ab800533f71 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -1069,7 +1069,7 @@ TEST_P(ParameterizedWebFrameTest, FixedLayoutInitializeAtMinimumScale)
webViewHelper.webView()->updateAllLifecyclePhases();
// Make sure we don't reset to initial scale if the page continues to load.
- webViewHelper.webViewImpl()->didCommitLoad(false, false);
+ webViewHelper.webViewImpl()->didCommitLoad(InitialCommitInChildFrame, false);
webViewHelper.webViewImpl()->didChangeContentsSize();
EXPECT_EQ(userPinchPageScaleFactor, webViewHelper.webView()->pageScaleFactor());
@@ -1106,7 +1106,7 @@ TEST_P(ParameterizedWebFrameTest, WideDocumentInitializeAtMinimumScale)
webViewHelper.webView()->updateAllLifecyclePhases();
// Make sure we don't reset to initial scale if the page continues to load.
- webViewHelper.webViewImpl()->didCommitLoad(false, false);
+ webViewHelper.webViewImpl()->didCommitLoad(InitialCommitInChildFrame, false);
webViewHelper.webViewImpl()->didChangeContentsSize();
EXPECT_EQ(userPinchPageScaleFactor, webViewHelper.webView()->pageScaleFactor());

Powered by Google App Engine
This is Rietveld 408576698