Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Side by Side Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 1596573002: Remove extra calls of didMeaningfulLayout() during the same navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 1051 matching lines...) Expand 10 before | Expand all | Expand 10 after
1062 float minimumPageScaleFactor = viewportWidth / (float) defaultFixedLayoutWid th; 1062 float minimumPageScaleFactor = viewportWidth / (float) defaultFixedLayoutWid th;
1063 EXPECT_EQ(minimumPageScaleFactor, webViewHelper.webViewImpl()->pageScaleFact or()); 1063 EXPECT_EQ(minimumPageScaleFactor, webViewHelper.webViewImpl()->pageScaleFact or());
1064 EXPECT_EQ(minimumPageScaleFactor, webViewHelper.webViewImpl()->minimumPageSc aleFactor()); 1064 EXPECT_EQ(minimumPageScaleFactor, webViewHelper.webViewImpl()->minimumPageSc aleFactor());
1065 1065
1066 // Assume the user has pinch zoomed to page scale factor 2. 1066 // Assume the user has pinch zoomed to page scale factor 2.
1067 float userPinchPageScaleFactor = 2; 1067 float userPinchPageScaleFactor = 2;
1068 webViewHelper.webView()->setPageScaleFactor(userPinchPageScaleFactor); 1068 webViewHelper.webView()->setPageScaleFactor(userPinchPageScaleFactor);
1069 webViewHelper.webView()->updateAllLifecyclePhases(); 1069 webViewHelper.webView()->updateAllLifecyclePhases();
1070 1070
1071 // Make sure we don't reset to initial scale if the page continues to load. 1071 // Make sure we don't reset to initial scale if the page continues to load.
1072 webViewHelper.webViewImpl()->didCommitLoad(false, false); 1072 webViewHelper.webViewImpl()->didCommitLoad(InitialCommitInChildFrame, false) ;
1073 webViewHelper.webViewImpl()->didChangeContentsSize(); 1073 webViewHelper.webViewImpl()->didChangeContentsSize();
1074 EXPECT_EQ(userPinchPageScaleFactor, webViewHelper.webView()->pageScaleFactor ()); 1074 EXPECT_EQ(userPinchPageScaleFactor, webViewHelper.webView()->pageScaleFactor ());
1075 1075
1076 // Make sure we don't reset to initial scale if the viewport size changes. 1076 // Make sure we don't reset to initial scale if the viewport size changes.
1077 webViewHelper.webView()->resize(WebSize(viewportWidth, viewportHeight + 100) ); 1077 webViewHelper.webView()->resize(WebSize(viewportWidth, viewportHeight + 100) );
1078 EXPECT_EQ(userPinchPageScaleFactor, webViewHelper.webView()->pageScaleFactor ()); 1078 EXPECT_EQ(userPinchPageScaleFactor, webViewHelper.webView()->pageScaleFactor ());
1079 } 1079 }
1080 1080
1081 TEST_P(ParameterizedWebFrameTest, WideDocumentInitializeAtMinimumScale) 1081 TEST_P(ParameterizedWebFrameTest, WideDocumentInitializeAtMinimumScale)
1082 { 1082 {
(...skipping 16 matching lines...) Expand all
1099 float minimumPageScaleFactor = viewportWidth / (float) wideDocumentWidth; 1099 float minimumPageScaleFactor = viewportWidth / (float) wideDocumentWidth;
1100 EXPECT_EQ(minimumPageScaleFactor, webViewHelper.webViewImpl()->pageScaleFact or()); 1100 EXPECT_EQ(minimumPageScaleFactor, webViewHelper.webViewImpl()->pageScaleFact or());
1101 EXPECT_EQ(minimumPageScaleFactor, webViewHelper.webViewImpl()->minimumPageSc aleFactor()); 1101 EXPECT_EQ(minimumPageScaleFactor, webViewHelper.webViewImpl()->minimumPageSc aleFactor());
1102 1102
1103 // Assume the user has pinch zoomed to page scale factor 2. 1103 // Assume the user has pinch zoomed to page scale factor 2.
1104 float userPinchPageScaleFactor = 2; 1104 float userPinchPageScaleFactor = 2;
1105 webViewHelper.webView()->setPageScaleFactor(userPinchPageScaleFactor); 1105 webViewHelper.webView()->setPageScaleFactor(userPinchPageScaleFactor);
1106 webViewHelper.webView()->updateAllLifecyclePhases(); 1106 webViewHelper.webView()->updateAllLifecyclePhases();
1107 1107
1108 // Make sure we don't reset to initial scale if the page continues to load. 1108 // Make sure we don't reset to initial scale if the page continues to load.
1109 webViewHelper.webViewImpl()->didCommitLoad(false, false); 1109 webViewHelper.webViewImpl()->didCommitLoad(InitialCommitInChildFrame, false) ;
1110 webViewHelper.webViewImpl()->didChangeContentsSize(); 1110 webViewHelper.webViewImpl()->didChangeContentsSize();
1111 EXPECT_EQ(userPinchPageScaleFactor, webViewHelper.webView()->pageScaleFactor ()); 1111 EXPECT_EQ(userPinchPageScaleFactor, webViewHelper.webView()->pageScaleFactor ());
1112 1112
1113 // Make sure we don't reset to initial scale if the viewport size changes. 1113 // Make sure we don't reset to initial scale if the viewport size changes.
1114 webViewHelper.webView()->resize(WebSize(viewportWidth, viewportHeight + 100) ); 1114 webViewHelper.webView()->resize(WebSize(viewportWidth, viewportHeight + 100) );
1115 EXPECT_EQ(userPinchPageScaleFactor, webViewHelper.webView()->pageScaleFactor ()); 1115 EXPECT_EQ(userPinchPageScaleFactor, webViewHelper.webView()->pageScaleFactor ());
1116 } 1116 }
1117 1117
1118 TEST_P(ParameterizedWebFrameTest, DelayedViewportInitialScale) 1118 TEST_P(ParameterizedWebFrameTest, DelayedViewportInitialScale)
1119 { 1119 {
(...skipping 7302 matching lines...) Expand 10 before | Expand all | Expand 10 after
8422 } 8422 }
8423 8423
8424 TEST_F(WebFrameVisibilityChangeTest, RemoteFrameParentVisibilityChange) 8424 TEST_F(WebFrameVisibilityChangeTest, RemoteFrameParentVisibilityChange)
8425 { 8425 {
8426 swapLocalFrameToRemoteFrame(); 8426 swapLocalFrameToRemoteFrame();
8427 executeScriptOnMainFrame(WebScriptSource("document.querySelector('iframe').p arentElement.style.display = 'none';")); 8427 executeScriptOnMainFrame(WebScriptSource("document.querySelector('iframe').p arentElement.style.display = 'none';"));
8428 EXPECT_FALSE(remoteFrameClient()->isVisible()); 8428 EXPECT_FALSE(remoteFrameClient()->isVisible());
8429 } 8429 }
8430 8430
8431 } // namespace blink 8431 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698