third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp - Issue 1596573002: Remove extra calls of didMeaningfulLayout() during the same navigation

Unified Diff: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

Issue 1596573002: Remove extra calls of didMeaningfulLayout() during the same navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/dom_distiller/distillable_page_utils_browsertest.cc ('K') | « chrome/test/data/dom_distiller/simple_article_iframe.html ('k') | third_party/WebKit/Source/web/WebViewImpl.h » ('j') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

index a954edf5bf42f080c9da7b9dc9fccdc2685f55f1..92c78b5c90d34d2bea396ed0ceeb0e59af20981a 100644

--- a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

+++ b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

@@ -449,8 +449,7 @@ void FrameLoaderClientImpl::dispatchDidReceiveServerRedirectForProvisionalLoad()

void FrameLoaderClientImpl::dispatchDidNavigateWithinPage(HistoryItem* item, HistoryCommitType commitType)

{

- bool shouldCreateHistoryEntry = commitType == StandardCommit;

- m_webFrame->viewImpl()->didCommitLoad(shouldCreateHistoryEntry, true);

+ m_webFrame->viewImpl()->didCommitLoad(commitType, true);

if (m_webFrame->client())

m_webFrame->client()->didNavigateWithinPage(m_webFrame, WebHistoryItem(item), static_cast<WebHistoryCommitType>(commitType));

}

@@ -481,7 +480,7 @@ void FrameLoaderClientImpl::dispatchDidChangeIcons(IconType type)

void FrameLoaderClientImpl::dispatchDidCommitLoad(HistoryItem* item, HistoryCommitType commitType)

{

- m_webFrame->viewImpl()->didCommitLoad(commitType == StandardCommit, false);

+ m_webFrame->viewImpl()->didCommitLoad(commitType, false);

dglazkov 2016/01/15 19:41:48 The bug is here. WebViewImpl::didCommitLoad only e

esprehn 2016/01/15 22:15:31 It should be trivial to write a test for this with

wychen 2016/01/15 22:31:02 Done.

wychen 2016/01/15 22:31:02 Could you elaborate a bit, or show me an example?

// Save some histogram data so we can compute the average memory used per

// page load of the glyphs.