Remove extra calls of didMeaningfulLayout() during the same navigation

third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

 /*
  * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 431 matching lines @@
 }
 
 void FrameLoaderClientImpl::dispatchDidReceiveServerRedirectForProvisionalLoad()
 {
     if (m_webFrame->client())
         m_webFrame->client()->didReceiveServerRedirectForProvisionalLoad(m_webFrame);
 }
 
 void FrameLoaderClientImpl::dispatchDidNavigateWithinPage(HistoryItem* item, HistoryCommitType commitType)
 {
-    bool shouldCreateHistoryEntry = commitType == StandardCommit;
-    m_webFrame->viewImpl()->didCommitLoad(shouldCreateHistoryEntry, true);
+    m_webFrame->viewImpl()->didCommitLoad(commitType, true);
     if (m_webFrame->client())
         m_webFrame->client()->didNavigateWithinPage(m_webFrame, WebHistoryItem(item), static_cast<WebHistoryCommitType>(commitType));
 }
 
 void FrameLoaderClientImpl::dispatchWillClose()
 {
     if (m_webFrame->client())
         m_webFrame->client()->willClose(m_webFrame);
 }
 
@@ skipping 10 matching lines @@
 }
 
 void FrameLoaderClientImpl::dispatchDidChangeIcons(IconType type)
 {
     if (m_webFrame->client())
         m_webFrame->client()->didChangeIcon(m_webFrame, static_cast<WebIconURL::Type>(type));
 }
 
 void FrameLoaderClientImpl::dispatchDidCommitLoad(HistoryItem* item, HistoryCommitType commitType)
 {
-    m_webFrame->viewImpl()->didCommitLoad(commitType == StandardCommit, false);
+    m_webFrame->viewImpl()->didCommitLoad(commitType, false);

[dglazkov, 2016/01/15 19:41:48]

The bug is here. WebViewImpl::didCommitLoad only expects to hear about main
frame load commit. Let's just not call it for other frames:

    if (!m_webFrame->parent())
        m_webFrame->viewImpl()->didCommitLoad(commitType == StandardCommit,
false);

[esprehn, 2016/01/15 22:15:31]

It should be trivial to write a test for this with Sim.

[wychen, 2016/01/15 22:31:02]

Done.

[wychen, 2016/01/15 22:31:02]

Could you elaborate a bit, or show me an example? I know it might take you
longer to explain than to write it yourself, but I'd like to learn this.

 
     // Save some histogram data so we can compute the average memory used per
     // page load of the glyphs.
     // TODO(esprehn): Is this ancient uma actually useful?
     Platform::current()->histogramCustomCounts("Memory.GlyphPagesPerLoad", GlyphPageTreeNode::treeGlyphPageCount(), 1, 10000, 50);
 
     if (m_webFrame->client())
         m_webFrame->client()->didCommitProvisionalLoad(m_webFrame, WebHistoryItem(item), static_cast<WebHistoryCommitType>(commitType));
     WebDevToolsAgentImpl* devToolsAgent = WebLocalFrameImpl::fromFrame(m_webFrame->frame()->localFrameRoot())->devToolsAgentImpl();
     if (devToolsAgent)
@@ skipping 506 matching lines @@
 
 void FrameLoaderClientImpl::suddenTerminationDisablerChanged(bool present, SuddenTerminationDisablerType type)
 {
     if (m_webFrame->client()) {
         m_webFrame->client()->suddenTerminationDisablerChanged(
             present, static_cast<WebFrameClient::SuddenTerminationDisablerType>(type));
     }
 }
 
 } // namespace blink