third_party/WebKit/Source/config.gni - Issue 1595813002: GN(android) Fix oscilloscope crash in webaudio on arm64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/config.gni

Issue 1595813002: GN(android) Fix oscilloscope crash in webaudio on arm64 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/config.gni

diff --git a/third_party/WebKit/Source/config.gni b/third_party/WebKit/Source/config.gni

index 6d584ff36caa39d008ddeac66db4907c216d4453..0ebc3addafcd1dc11cda30688f2dd5566cbc3e56 100644

--- a/third_party/WebKit/Source/config.gni

+++ b/third_party/WebKit/Source/config.gni

@@ -31,9 +31,9 @@ declare_args() {

# enabled. Whether WebAudio is actually available depends on runtime settings

Raymond Toy 2016/01/16 03:12:34 Can you update these comments to say arm64 and mip

agrieve 2016/01/16 03:18:09 Done.

# and flags.

use_openmax_dl_fft =

- is_android &&

- (current_cpu == "x86" || current_cpu == "x64" ||

- (current_cpu == "arm" && arm_version >= 7) || current_cpu == "mipsel")

+ is_android && (current_cpu == "x86" || current_cpu == "x64" ||

+ (current_cpu == "arm" && arm_version >= 7) ||

+ current_cpu == "arm64" || current_cpu == "mipsel")

use_webaudio_ffmpeg = !is_mac && !is_android

« no previous file with comments | « no previous file | no next file » | no next file with comments »