Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: third_party/WebKit/Source/config.gni

Issue 1595813002: GN(android) Fix oscilloscope crash in webaudio on arm64 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/ui.gni") 5 import("//build/config/ui.gni")
6 import("//third_party/WebKit/public/features.gni") 6 import("//third_party/WebKit/public/features.gni")
7 7
8 if (is_android) { 8 if (is_android) {
9 import("//build/config/android/config.gni") 9 import("//build/config/android/config.gni")
10 } 10 }
(...skipping 10 matching lines...) Expand all
21 blink_gc_plugin = true 21 blink_gc_plugin = true
22 22
23 # If true, force blink asserts to be off in a release build. When false, 23 # If true, force blink asserts to be off in a release build. When false,
24 # blink asserts in release build may be controlled by DCHECK_ALWAYS_ON. 24 # blink asserts in release build may be controlled by DCHECK_ALWAYS_ON.
25 blink_asserts_off_in_release = false 25 blink_asserts_off_in_release = false
26 } 26 }
27 27
28 # Whether Android ARM or x86 build uses OpenMAX DL FFT. Currently only 28 # Whether Android ARM or x86 build uses OpenMAX DL FFT. Currently only
29 # supported on Android ARMv7+, ia32 or x64 without webview. When enabled, this 29 # supported on Android ARMv7+, ia32 or x64 without webview. When enabled, this
30 # will also enable WebAudio support on Android ARM, ia32 and x64. Default is 30 # will also enable WebAudio support on Android ARM, ia32 and x64. Default is
31 # enabled. Whether WebAudio is actually available depends on runtime settings 31 # enabled. Whether WebAudio is actually available depends on runtime settings
Raymond Toy 2016/01/16 03:12:34 Can you update these comments to say arm64 and mip
agrieve 2016/01/16 03:18:09 Done.
32 # and flags. 32 # and flags.
33 use_openmax_dl_fft = 33 use_openmax_dl_fft =
34 is_android && 34 is_android && (current_cpu == "x86" || current_cpu == "x64" ||
35 (current_cpu == "x86" || current_cpu == "x64" || 35 (current_cpu == "arm" && arm_version >= 7) ||
36 (current_cpu == "arm" && arm_version >= 7) || current_cpu == "mipsel") 36 current_cpu == "arm64" || current_cpu == "mipsel")
37 37
38 use_webaudio_ffmpeg = !is_mac && !is_android 38 use_webaudio_ffmpeg = !is_mac && !is_android
39 39
40 # Set this to true to enable use of concatenated impulse responses for the HRTF 40 # Set this to true to enable use of concatenated impulse responses for the HRTF
41 # panner in WebAudio. 41 # panner in WebAudio.
42 # TODO(brettw) do we need this or can we assume its always on? 42 # TODO(brettw) do we need this or can we assume its always on?
43 use_concatenated_impulse_responses = true 43 use_concatenated_impulse_responses = true
44 44
45 # feature_defines_list --------------------------------------------------------- 45 # feature_defines_list ---------------------------------------------------------
46 46
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 } 92 }
93 93
94 # feature_defines_string ------------------------------------------------------- 94 # feature_defines_string -------------------------------------------------------
95 95
96 # Convert the list to a space-separated string for passing to scripts. 96 # Convert the list to a space-separated string for passing to scripts.
97 # This would be the equivalent of passing '<(feature_defines)' in GYP. 97 # This would be the equivalent of passing '<(feature_defines)' in GYP.
98 feature_defines_string = 98 feature_defines_string =
99 exec_script("build/gn_list_to_space_separated_string.py", 99 exec_script("build/gn_list_to_space_separated_string.py",
100 feature_defines_list, 100 feature_defines_list,
101 "trim string") 101 "trim string")
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698