Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1595813002: GN(android) Fix oscilloscope crash in webaudio on arm64 (Closed)

Created:
4 years, 11 months ago by agrieve
Modified:
4 years, 11 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN(android) Fix oscilloscope crash in webaudio on arm64 TBR=dpranke BUG=578209 Committed: https://crrev.com/c6458dafbea2ec536e8f9a9793f9af47600ef743 Cr-Commit-Position: refs/heads/master@{#369941}

Patch Set 1 #

Total comments: 2

Patch Set 2 : update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M third_party/WebKit/Source/config.gni View 1 1 chunk +6 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (8 generated)
agrieve
Verified on my device that this fixes the crash.
4 years, 11 months ago (2016-01-16 02:24:49 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1595813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1595813002/1
4 years, 11 months ago (2016-01-16 02:25:15 UTC) #4
Raymond Toy
lgtm, with a nit. Thanks so much for fixing this! https://codereview.chromium.org/1595813002/diff/1/third_party/WebKit/Source/config.gni File third_party/WebKit/Source/config.gni (right): https://codereview.chromium.org/1595813002/diff/1/third_party/WebKit/Source/config.gni#newcode31 ...
4 years, 11 months ago (2016-01-16 03:12:34 UTC) #5
agrieve
https://codereview.chromium.org/1595813002/diff/1/third_party/WebKit/Source/config.gni File third_party/WebKit/Source/config.gni (right): https://codereview.chromium.org/1595813002/diff/1/third_party/WebKit/Source/config.gni#newcode31 third_party/WebKit/Source/config.gni:31: # enabled. Whether WebAudio is actually available depends on ...
4 years, 11 months ago (2016-01-16 03:18:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1595813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1595813002/20001
4 years, 11 months ago (2016-01-16 03:19:15 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-16 05:10:58 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c6458dafbea2ec536e8f9a9793f9af47600ef743 Cr-Commit-Position: refs/heads/master@{#369941}
4 years, 11 months ago (2016-01-16 05:12:19 UTC) #14
Dirk Pranke
4 years, 11 months ago (2016-01-16 19:40:51 UTC) #16
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698