Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 11 months ago by agrieve Modified:
4 years, 11 months ago Reviewers:
Dirk Pranke, Raymond Toy CC:
blink-reviews, chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionGN(android) Fix oscilloscope crash in webaudio on arm64
TBR=dpranke
BUG=578209
Committed: https://crrev.com/c6458dafbea2ec536e8f9a9793f9af47600ef743
Cr-Commit-Position: refs/heads/master@{#369941}
Patch Set 1 #
Total comments: 2
Patch Set 2 : update comment #
Created: 4 years, 11 months ago
Depends on Patchset: Messages
Total messages: 16 (8 generated)
agrieve@chromium.org changed reviewers: + rtoy@chromium.org
Verified on my device that this fixes the crash.
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1595813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1595813002/1
lgtm, with a nit. Thanks so much for fixing this! https://codereview.chromium.org/1595813002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/config.gni (right): https://codereview.chromium.org/1595813002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/config.gni:31: # enabled. Whether WebAudio is actually available depends on runtime settings Can you update these comments to say arm64 and mipsel are also supported?
https://codereview.chromium.org/1595813002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/config.gni (right): https://codereview.chromium.org/1595813002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/config.gni:31: # enabled. Whether WebAudio is actually available depends on runtime settings On 2016/01/16 03:12:34, Raymond Toy wrote: > Can you update these comments to say arm64 and mipsel are also supported? Done.
Description was changed from ========== GN(android) Fix oscilloscope crash in webaudio on arm64 BUG=578209 ========== to ========== GN(android) Fix oscilloscope crash in webaudio on arm64 TBR=dpranke BUG=578209 ==========
The CQ bit was checked by agrieve@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rtoy@chromium.org Link to the patchset: https://codereview.chromium.org/1595813002/#ps20001 (title: "update comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1595813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1595813002/20001
Message was sent while issue was closed.
Description was changed from ========== GN(android) Fix oscilloscope crash in webaudio on arm64 TBR=dpranke BUG=578209 ========== to ========== GN(android) Fix oscilloscope crash in webaudio on arm64 TBR=dpranke BUG=578209 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== GN(android) Fix oscilloscope crash in webaudio on arm64 TBR=dpranke BUG=578209 ========== to ========== GN(android) Fix oscilloscope crash in webaudio on arm64 TBR=dpranke BUG=578209 Committed: https://crrev.com/c6458dafbea2ec536e8f9a9793f9af47600ef743 Cr-Commit-Position: refs/heads/master@{#369941} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c6458dafbea2ec536e8f9a9793f9af47600ef743 Cr-Commit-Position: refs/heads/master@{#369941}
Message was sent while issue was closed.
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
Message was sent while issue was closed.
lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
