Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1595793002: Revert of Add <link rel=preload> onload support for scripts and styles (Closed)

Created:
4 years, 11 months ago by samuong
Modified:
4 years, 11 months ago
Reviewers:
Yoav Weiss, Nate Chapin
CC:
chromium-reviews, tyoshino+watch_chromium.org, gavinp+prerender_chromium.org, blink-reviews-style_chromium.org, blink-reviews-html_chromium.org, loading-reviews_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add <link rel=preload> onload support for scripts and styles (patchset #11 id:200001 of https://codereview.chromium.org/1577073005/ ) Reason for revert: it broke the compile step on the WebKit Linux Oilpan Builder: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan%20Builder/builds/451 Original issue's description: > Add <link rel=preload> onload support for scripts and styles > > This CL adds onload support for <link rel=preload> for scripts and styles. > > Support for other resource types will be added in a followup CL. > > BUG=552289 > > Committed: https://crrev.com/f85424718ca7a8ea3f330141ee68b717ae02f2f0 > Cr-Commit-Position: refs/heads/master@{#369892} TBR=japhet@chromium.org,yoav@yoav.ws # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=552289 Committed: https://crrev.com/9c44829b387dee90ccb64b1dccebce206bb2aae0 Cr-Commit-Position: refs/heads/master@{#369897}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -194 lines) Patch
D third_party/WebKit/LayoutTests/http/tests/preload/onload_event.html View 1 chunk +0 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoader.h View 4 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoader.cpp View 4 chunks +33 lines, -64 lines 0 comments Download
D third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h View 1 chunk +0 lines, -84 lines 0 comments Download
D third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.cpp View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
samuong
Created Revert of Add <link rel=preload> onload support for scripts and styles
4 years, 11 months ago (2016-01-16 00:48:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1595793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1595793002/1
4 years, 11 months ago (2016-01-16 00:49:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-16 00:50:35 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9c44829b387dee90ccb64b1dccebce206bb2aae0 Cr-Commit-Position: refs/heads/master@{#369897}
4 years, 11 months ago (2016-01-16 00:51:44 UTC) #5
Yoav Weiss
4 years, 11 months ago (2016-01-16 06:04:28 UTC) #6
Message was sent while issue was closed.
On 2016/01/16 00:51:44, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/9c44829b387dee90ccb64b1dccebce206bb2aae0
> Cr-Commit-Position: refs/heads/master@{#369897}

LGTM. 
If we're reverting due to breaking of the Oilpan build, why isn't it blocking
CQ?

Powered by Google App Engine
This is Rietveld 408576698