Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1595763002: Merge to XFA: Make pdfium_test report build options. (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Make pdfium_test report build options. Review URL: https://codereview.chromium.org/1587023005 . (cherry picked from commit 041ed75701d1edc15923daf6080224a67b480869) TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/2991d8d171e917912fd250c3c8ed693568dc1d8c

Patch Set 1 : Original patch #

Patch Set 2 : Manually add XFA. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -8 lines) Patch
M samples/pdfium_test.cc View 1 5 chunks +41 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
TBR, one trivial manual change between ps1 and ps2.
4 years, 11 months ago (2016-01-16 00:02:26 UTC) #1
Tom Sepez
Committed patchset #2 (id:20001) manually as 2991d8d171e917912fd250c3c8ed693568dc1d8c (presubmit successful).
4 years, 11 months ago (2016-01-16 00:02:52 UTC) #3
Lei Zhang
4 years, 11 months ago (2016-01-16 00:05:05 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698