Make pdfium_test report build options.

Make pdfium_test report build options.

Prerequisite for suppressing tests based on build options.
We explicitly delimit everything with [x] so as to make
substring matching trivial in the .py down the road.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/041ed75701d1edc15923daf6080224a67b480869

[Tom Sepez, 2016-01-15 17:27:35]

Description was changed from

==========
Make pdfium_test report build options.
==========

to

==========
Make pdfium_test report build options.

Prerequisite for suppressing tests based on build options.
==========

[Tom Sepez, 2016-01-15 17:27:35]

tsepez@chromium.org changed reviewers:
+ jun_fang@foxitsoftware.com, thestig@chromium.org

[Tom Sepez, 2016-01-15 17:29:50]

Pls. review.

https://codereview.chromium.org/1587023005/diff/20001/samples/pdfium_test.cc
File samples/pdfium_test.cc (right):

https://codereview.chromium.org/1587023005/diff/20001/samples/pdfium_test.cc#...
samples/pdfium_test.cc:540: config.append(comma);
not strictly required, but allows adding/shuffling these blocks in any order.

[Tom Sepez, 2016-01-15 17:34:40]

Description was changed from

==========
Make pdfium_test report build options.

Prerequisite for suppressing tests based on build options.
==========

to

==========
Make pdfium_test report build options.

Prerequisite for suppressing tests based on build options. We
explicitly delimit everything with [x] so as to make substring matching trivial
in the .py down the road.
==========

[Tom Sepez, 2016-01-15 17:34:58]

Description was changed from

==========
Make pdfium_test report build options.

Prerequisite for suppressing tests based on build options. We
explicitly delimit everything with [x] so as to make substring matching trivial
in the .py down the road.
==========

to

==========
Make pdfium_test report build options.

Prerequisite for suppressing tests based on build options.
We explicitly delimit everything with [x] so as to make
substring matching trivial in the .py down the road.
==========

[Tom Sepez, 2016-01-15 17:35:36]

https://codereview.chromium.org/1587023005/diff/20001/samples/pdfium_test.cc
File samples/pdfium_test.cc (right):

https://codereview.chromium.org/1587023005/diff/20001/samples/pdfium_test.cc#...
samples/pdfium_test.cc:540: config.append(comma);
On 2016/01/15 17:29:50, Tom Sepez wrote:
> not strictly required, but allows adding/shuffling these blocks in any order.

... and its gone.

[Lei Zhang, 2016-01-15 20:14:49]

lgtm

Maybe a comma delimiter is even easier for Python to parse, but it adds a wee
bit more complexity here.</bikeshed>

[Tom Sepez, 2016-01-15 23:48:36]

On 2016/01/15 20:14:49, Lei Zhang wrote:
> lgtm
> 
> Maybe a comma delimiter is even easier for Python to parse, but it adds a wee
> bit more complexity here.</bikeshed>
Yeah, was thinking about [V8] in string rather than V8 in string.split(","). No
matter.  I'll put the comma back.

[Tom Sepez, 2016-01-15 23:55:00]

Description was changed from

==========
Make pdfium_test report build options.

Prerequisite for suppressing tests based on build options.
We explicitly delimit everything with [x] so as to make
substring matching trivial in the .py down the road.
==========

to

==========
Make pdfium_test report build options.

Prerequisite for suppressing tests based on build options.
We explicitly delimit everything with [x] so as to make
substring matching trivial in the .py down the road.

R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/041ed75701d1edc15923daf6080224a67b48...
==========

[Tom Sepez, 2016-01-15 23:55:01]

Committed patchset #5 (id:80001) manually as
041ed75701d1edc15923daf6080224a67b480869 (presubmit successful).