third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp - Issue 1595713003: Make ReadableStreamOperations use ScriptValue

Unified Diff: third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp

Issue 1595713003: Make ReadableStreamOperations use ScriptValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix comment and add a couple asserts Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp ('k') | third_party/WebKit/Source/modules/fetch/Response.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp b/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp

index 1356bcdd97904213162d46a2cff50533d32405da..347519606c5bc74d875fa2a4377fcd9699aeb977 100644

--- a/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp

+++ b/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp

@@ -87,7 +87,7 @@ TEST_F(ReadableStreamDataConsumerHandleTest, Create)

ScriptState::Scope scope(scriptState());

ScriptValue stream(scriptState(), evalWithPrintingError("new ReadableStream"));

ASSERT_FALSE(stream.isEmpty());

- OwnPtr<ReadableStreamDataConsumerHandle> handle = ReadableStreamDataConsumerHandle::create(scriptState(), stream.v8Value());

+ OwnPtr<ReadableStreamDataConsumerHandle> handle = ReadableStreamDataConsumerHandle::create(scriptState(), stream);

ASSERT_TRUE(handle);

MockClient* client = MockClient::create();

Checkpoint checkpoint;

@@ -110,7 +110,7 @@ TEST_F(ReadableStreamDataConsumerHandleTest, EmptyStream)

ScriptValue stream(scriptState(), evalWithPrintingError(

"new ReadableStream({start: c => c.close()})"));

ASSERT_FALSE(stream.isEmpty());

- OwnPtr<ReadableStreamDataConsumerHandle> handle = ReadableStreamDataConsumerHandle::create(scriptState(), stream.v8Value());

+ OwnPtr<ReadableStreamDataConsumerHandle> handle = ReadableStreamDataConsumerHandle::create(scriptState(), stream);

ASSERT_TRUE(handle);

MockClient* client = MockClient::create();

Checkpoint checkpoint;

@@ -141,7 +141,7 @@ TEST_F(ReadableStreamDataConsumerHandleTest, ErroredStream)

ScriptValue stream(scriptState(), evalWithPrintingError(

"new ReadableStream({start: c => c.error()})"));

ASSERT_FALSE(stream.isEmpty());

- OwnPtr<ReadableStreamDataConsumerHandle> handle = ReadableStreamDataConsumerHandle::create(scriptState(), stream.v8Value());

+ OwnPtr<ReadableStreamDataConsumerHandle> handle = ReadableStreamDataConsumerHandle::create(scriptState(), stream);

ASSERT_TRUE(handle);

MockClient* client = MockClient::create();

Checkpoint checkpoint;

@@ -177,7 +177,7 @@ TEST_F(ReadableStreamDataConsumerHandleTest, Read)

"controller.close();"

"stream"));

ASSERT_FALSE(stream.isEmpty());

- OwnPtr<ReadableStreamDataConsumerHandle> handle = ReadableStreamDataConsumerHandle::create(scriptState(), stream.v8Value());

+ OwnPtr<ReadableStreamDataConsumerHandle> handle = ReadableStreamDataConsumerHandle::create(scriptState(), stream);

ASSERT_TRUE(handle);

MockClient* client = MockClient::create();

Checkpoint checkpoint;

@@ -239,7 +239,7 @@ TEST_F(ReadableStreamDataConsumerHandleTest, TwoPhaseRead)

"controller.close();"

"stream"));

ASSERT_FALSE(stream.isEmpty());

- OwnPtr<ReadableStreamDataConsumerHandle> handle = ReadableStreamDataConsumerHandle::create(scriptState(), stream.v8Value());

+ OwnPtr<ReadableStreamDataConsumerHandle> handle = ReadableStreamDataConsumerHandle::create(scriptState(), stream);

ASSERT_TRUE(handle);

MockClient* client = MockClient::create();

Checkpoint checkpoint;

@@ -309,7 +309,7 @@ TEST_F(ReadableStreamDataConsumerHandleTest, LockedStream)

"stream.getReader();"

"stream"));

ASSERT_FALSE(stream.isEmpty());

- OwnPtr<ReadableStreamDataConsumerHandle> handle = ReadableStreamDataConsumerHandle::create(scriptState(), stream.v8Value());

+ OwnPtr<ReadableStreamDataConsumerHandle> handle = ReadableStreamDataConsumerHandle::create(scriptState(), stream);

ASSERT_TRUE(handle);

MockClient* client = MockClient::create();

Checkpoint checkpoint;

@@ -339,7 +339,7 @@ TEST_F(ReadableStreamDataConsumerHandleTest, EnqueueUndefined)

"controller.close();"

"stream"));

ASSERT_FALSE(stream.isEmpty());

- OwnPtr<ReadableStreamDataConsumerHandle> handle = ReadableStreamDataConsumerHandle::create(scriptState(), stream.v8Value());

+ OwnPtr<ReadableStreamDataConsumerHandle> handle = ReadableStreamDataConsumerHandle::create(scriptState(), stream);

ASSERT_TRUE(handle);

MockClient* client = MockClient::create();

Checkpoint checkpoint;

@@ -374,7 +374,7 @@ TEST_F(ReadableStreamDataConsumerHandleTest, EnqueueNull)

"controller.close();"

"stream"));

ASSERT_FALSE(stream.isEmpty());

- OwnPtr<ReadableStreamDataConsumerHandle> handle = ReadableStreamDataConsumerHandle::create(scriptState(), stream.v8Value());

+ OwnPtr<ReadableStreamDataConsumerHandle> handle = ReadableStreamDataConsumerHandle::create(scriptState(), stream);

ASSERT_TRUE(handle);

MockClient* client = MockClient::create();

Checkpoint checkpoint;

@@ -409,7 +409,7 @@ TEST_F(ReadableStreamDataConsumerHandleTest, EnqueueString)

"controller.close();"

"stream"));

ASSERT_FALSE(stream.isEmpty());

- OwnPtr<ReadableStreamDataConsumerHandle> handle = ReadableStreamDataConsumerHandle::create(scriptState(), stream.v8Value());

+ OwnPtr<ReadableStreamDataConsumerHandle> handle = ReadableStreamDataConsumerHandle::create(scriptState(), stream);

ASSERT_TRUE(handle);

MockClient* client = MockClient::create();

Checkpoint checkpoint;