third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp - Issue 1595713003: Make ReadableStreamOperations use ScriptValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp

Issue 1595713003: Make ReadableStreamOperations use ScriptValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix comment and add a couple asserts Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.h ('k') | third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp b/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp

index 024681813fa74a03b2dccfeb34913e54178b00e1..449b0e6872a5a0a57e469eda5d442aeeb27a18a8 100644

--- a/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp

+++ b/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp

@@ -119,7 +119,7 @@ public:

RefPtr<ReadingContext> m_readingContext;

};

- static PassRefPtr<ReadingContext> create(ScriptState* scriptState, v8::Local<v8::Value> stream)

+ static PassRefPtr<ReadingContext> create(ScriptState* scriptState, ScriptValue stream)

{

return adoptRef(new ReadingContext(scriptState, stream));

}

@@ -156,7 +156,7 @@ public:

m_isReading = true;

ScriptState::Scope scope(m_reader.scriptState());

V8RecursionScope recursionScope(m_reader.isolate());

- ReadableStreamOperations::read(m_reader.scriptState(), m_reader.v8Value()).then(

+ ReadableStreamOperations::read(m_reader.scriptState(), m_reader).then(

OnFulfilled::createFunction(m_reader.scriptState(), m_weakPtrFactory.createWeakPtr()),

OnRejected::createFunction(m_reader.scriptState(), m_weakPtrFactory.createWeakPtr()));

// Note: Microtasks may run here.

@@ -226,7 +226,7 @@ public:

}

private:

- ReadingContext(ScriptState* scriptState, v8::Local<v8::Value> stream)

+ ReadingContext(ScriptState* scriptState, ScriptValue stream)

: m_client(nullptr)

, m_weakPtrFactory(this)

, m_pendingOffset(0)

@@ -260,7 +260,7 @@ private:

bool m_isInRecursion;

};

-ReadableStreamDataConsumerHandle::ReadableStreamDataConsumerHandle(ScriptState* scriptState, v8::Local<v8::Value> stream)

+ReadableStreamDataConsumerHandle::ReadableStreamDataConsumerHandle(ScriptState* scriptState, ScriptValue stream)

: m_readingContext(ReadingContext::create(scriptState, stream))

{

}