Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.h

Issue 1595713003: Make ReadableStreamOperations use ScriptValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comment and add a couple asserts Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.h
diff --git a/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.h b/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.h
index 9c634f73d990d6da1e947994a59f1d2c7e7f6080..1d80665ea6acae5ae936b862d2543a5c2e12cef1 100644
--- a/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.h
+++ b/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.h
@@ -5,12 +5,12 @@
#ifndef ReadableStreamDataConsumerHandle_h
#define ReadableStreamDataConsumerHandle_h
+#include "bindings/core/v8/ScriptValue.h"
#include "modules/ModulesExport.h"
#include "modules/fetch/FetchDataConsumerHandle.h"
#include "wtf/Forward.h"
#include "wtf/PassOwnPtr.h"
#include "wtf/RefPtr.h"
-#include <v8.h>
namespace blink {
@@ -28,7 +28,7 @@ class ScriptState;
class MODULES_EXPORT ReadableStreamDataConsumerHandle final : public FetchDataConsumerHandle {
WTF_MAKE_NONCOPYABLE(ReadableStreamDataConsumerHandle);
public:
- static PassOwnPtr<ReadableStreamDataConsumerHandle> create(ScriptState* scriptState, v8::Local<v8::Value> stream)
+ static PassOwnPtr<ReadableStreamDataConsumerHandle> create(ScriptState* scriptState, ScriptValue stream)
{
return adoptPtr(new ReadableStreamDataConsumerHandle(scriptState, stream));
}
@@ -36,7 +36,7 @@ public:
private:
class ReadingContext;
- ReadableStreamDataConsumerHandle(ScriptState*, v8::Local<v8::Value> stream);
+ ReadableStreamDataConsumerHandle(ScriptState*, ScriptValue stream);
Reader* obtainReaderInternal(Client*) override;
const char* debugName() const override { return "ReadableStreamDataConsumerHandle"; }

Powered by Google App Engine
This is Rietveld 408576698