Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1595613002: Dart: Remove shutdown workarounds. (Closed)

Created:
4 years, 11 months ago by zra
Modified:
4 years, 11 months ago
Reviewers:
Cutch
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M mojo/dart/embedder/dart_controller.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M services/dart/content_handler_main.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
John, do you remember any other workarounds that we added?
4 years, 11 months ago (2016-01-15 19:20:58 UTC) #2
Cutch
AFAIK these are the only two hacks in place. LGTM
4 years, 11 months ago (2016-01-15 20:51:11 UTC) #3
zra
4 years, 11 months ago (2016-01-15 21:05:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0fbbc8b62106a48038cb7cb6b155909985fc2982 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698