Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: mojo/dart/embedder/dart_controller.cc

Issue 1595613002: Dart: Remove shutdown workarounds. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | services/dart/content_handler_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/dart/embedder/dart_controller.cc
diff --git a/mojo/dart/embedder/dart_controller.cc b/mojo/dart/embedder/dart_controller.cc
index b727c5f06301e98c8e3cb3282866812296b6682a..0d3da6ff9042cf0025a7681f7c56419b338244d8 100644
--- a/mojo/dart/embedder/dart_controller.cc
+++ b/mojo/dart/embedder/dart_controller.cc
@@ -611,14 +611,6 @@ void DartController::InitVmIfNeeded(Dart_EntropySource entropy,
handle_watcher_producer_handle_ = HandleWatcher::Start();
const char* kControllerFlags[] = {
- // TODO(zra): Fix Dart VM Shutdown race.
- // There is a bug in Dart VM shutdown which causes its thread pool threads
- // to potentially fail to exit when the rest of the VM is going down. This
- // results in a segfault if they begin running again after the Dart
- // embedder has been unloaded. Setting this flag to 0 ensures that these
- // threads sleep forever instead of waking up and trying to run code
- // that isn't there anymore.
- "--worker-timeout-millis=0",
// Disable access dart:mirrors library.
"--enable_mirrors=false",
// Force await and async to be keywords even outside of an async function.
« no previous file with comments | « no previous file | services/dart/content_handler_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698