Issue 15956004: Disk cache: Avoid writing uninitialized data to disk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15956004: Disk cache: Avoid writing uninitialized data to disk. (Closed)

Created:
7 years, 7 months ago by rvargas (doing something else)

Modified:
7 years, 7 months ago

Reviewers:
gavinp

CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Disk cache: Avoid writing uninitialized data to disk. r201943 is writing to disk some random bytes after the stats. That is fine because we never use the random data again, but the memory bots are not happy, so limit the size of the write. BUG=241277 TEST=green mem bots TBR=gavinp@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201962

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -7 lines)			Patch
M	net/disk_cache/backend_impl.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	net/disk_cache/stats.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/disk_cache/stats.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rvargas (doing something else)

7 years, 7 months ago (2013-05-24 01:54:20 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r201962 (presubmit successful).

Expand Messages | Collapse Messages