Disk cache: Avoid writing uninitialized data to disk.

net/disk_cache/stats.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/disk_cache/stats.h"
 
 #include "base/format_macros.h"
 #include "base/logging.h"
 #include "base/metrics/histogram_samples.h"
 #include "base/string_util.h"
@@ skipping 189 matching lines @@
 int Stats::GetLargeEntriesSize() {
   int total = 0;
   // data_sizes_[20] stores values between 512 KB and 1 MB (see comment before
   // GetStatsBucket()).
   for (int bucket = 20; bucket < kDataSizesLength; bucket++)
     total += data_sizes_[bucket] * GetBucketRange(bucket);
 
   return total;
 }
 
-bool Stats::SerializeStats(void* data, int num_bytes, Addr* address) {
+int Stats::SerializeStats(void* data, int num_bytes, Addr* address) {
   OnDiskStats* stats = reinterpret_cast<OnDiskStats*>(data);
   if (num_bytes < static_cast<int>(sizeof(*stats)))
-    return false;
+    return 0;
 
   stats->signature = kDiskSignature;
   stats->size = sizeof(stats);
   memcpy(stats->data_sizes, data_sizes_, sizeof(data_sizes_));
   memcpy(stats->counters, counters_, sizeof(counters_));
 
   *address = storage_addr_;
-  return true;
+  return sizeof(*stats);
 }
 
 int Stats::GetBucketRange(size_t i) const {
   if (i < 2)
     return static_cast<int>(1024 * i);
 
   if (i < 12)
     return static_cast<int>(2048 * (i - 1));
 
   if (i < 17)
@@ skipping 65 matching lines @@
 int Stats::GetRatio(Counters hit, Counters miss) const {
   int64 ratio = GetCounter(hit) * 100;
   if (!ratio)
     return 0;
 
   ratio /= (GetCounter(hit) + GetCounter(miss));
   return static_cast<int>(ratio);
 }
 
 }  // namespace disk_cache