Chromium Code Reviews
Help | Chromium Project | Sign in
(30)

Issue 15955009: Call vaInitialize() at PreSandbox stage.

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by haltonhuo
Modified:
2 years, 11 months ago
Reviewers:
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Call vaInitialize() at PreSandbox stage. libva will dlopen driver when vaInitialize() get called. This call should be called before sandboxing otherwise it will fail. BUG=244386 TEST=ppapi_example_video_decode

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase to r252515 #

Patch Set 3 : rebase to r257620 #

Patch Set 4 : rebase to r265896, remove message loop dependency, use XOpenDisplay directly. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -10 lines) Patch
M content/common/sandbox_linux/bpf_gpu_policy_linux.cc View 1 2 3 4 chunks +41 lines, -10 lines 0 comments Download
Trybot results: Sign in to try more bots
Commit queue not available (can’t edit this change).

Messages

Total messages: 24 (0 generated)
haltonhuo
3 years, 11 months ago (2013-05-31 11:08:20 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
3 years, 11 months ago (2013-05-31 11:08:43 UTC) #2
Ami GONE FROM CHROMIUM
This change makes me sad. We intentionally minimize the work done in PreSandbox, not only ...
3 years, 11 months ago (2013-05-31 16:19:24 UTC) #3
Pawel Osciak
On 2013/05/31 11:08:20, haltonhuo wrote: I'm confused, what is this fixing? I'm not aware of ...
3 years, 11 months ago (2013-05-31 16:25:36 UTC) #4
Pawel Osciak
Please also always add me as reviewer on all VAAPI-related CLs.
3 years, 11 months ago (2013-05-31 16:26:24 UTC) #5
Jorge Lucangeli Obes
On 2013/05/31 16:26:24, posciak wrote: > Please also always add me as reviewer on all ...
3 years, 11 months ago (2013-05-31 17:29:15 UTC) #6
haltonhuo
On 2013/05/31 17:29:15, Jorge Lucangeli Obes wrote: > Please don't land this until we understand ...
3 years, 11 months ago (2013-06-03 02:05:17 UTC) #7
Pawel Osciak
On 2013/06/03 02:05:17, haltonhuo wrote: > On 2013/05/31 17:29:15, Jorge Lucangeli Obes wrote: > > ...
3 years, 11 months ago (2013-06-03 16:09:10 UTC) #8
Ami GONE FROM CHROMIUM
On Mon, Jun 3, 2013 at 9:09 AM, <posciak@chromium.org> wrote: > We use vaapi only ...
3 years, 11 months ago (2013-06-03 16:31:09 UTC) #9
Jorge Lucangeli Obes
On 2013/06/03 16:31:09, Ami Fischman wrote: > On Mon, Jun 3, 2013 at 9:09 AM, ...
3 years, 11 months ago (2013-06-03 16:41:23 UTC) #10
Ami GONE FROM CHROMIUM
Makes sense. (also, I hadn't seen that we hard-code the cros paths before) On Mon, ...
3 years, 11 months ago (2013-06-03 16:42:37 UTC) #11
haltonhuo
On 2013/06/03 16:09:10, posciak wrote: > > We use vaapi only on CrOS and currently ...
3 years, 11 months ago (2013-06-04 01:15:19 UTC) #12
Ami GONE FROM CHROMIUM
I decided not to make vavda/linux a supported configuration because the distro/drivers/hardware fragmentation imposes a ...
3 years, 11 months ago (2013-06-04 02:21:56 UTC) #13
haltonhuo
On 2013/06/04 02:21:56, Ami Fischman wrote: > I decided not to make vavda/linux a supported ...
3 years, 11 months ago (2013-06-04 03:40:36 UTC) #14
Ami GONE FROM CHROMIUM
> > It is a pity that linux users can not benefit the HW video ...
3 years, 11 months ago (2013-06-04 04:03:34 UTC) #15
haltonhuo
On 2013/06/04 04:03:34, Ami Fischman wrote: > If it was "little effort" I'd agree. It ...
3 years, 11 months ago (2013-06-04 06:56:32 UTC) #16
Ami GONE FROM CHROMIUM
I believe this is a bad idea. I think you are severly underestimating the maintenance ...
3 years, 10 months ago (2013-06-04 19:33:11 UTC) #17
haltonhuo
On 2013/06/04 19:33:11, Ami Fischman wrote: > I believe this is a bad idea. > ...
3 years, 10 months ago (2013-06-05 06:25:24 UTC) #18
haltonhuo
On 2013/06/05 06:25:24, haltonhuo wrote: > Thanks for your kind follow-up and explanation. No, I ...
3 years, 10 months ago (2013-06-05 06:27:16 UTC) #19
Ami GONE FROM CHROMIUM
I suggest you star https://code.google.com/p/chromium/issues/detail?id=137247 to stay updated on changes in prioritization of this feature. ...
3 years, 10 months ago (2013-06-05 06:29:33 UTC) #20
haltonhuo
On 2013/06/05 06:29:33, Ami Fischman wrote: > I suggest you star > https://code.google.com/p/chromium/issues/detail?id=137247 to stay ...
3 years, 10 months ago (2013-06-05 07:54:59 UTC) #21
Ami GONE FROM CHROMIUM
Removing myself as reviewer to remove this from my CL list.
3 years, 6 months ago (2013-10-31 21:28:51 UTC) #22
Jorge Lucangeli Obes
On 2013/10/31 21:28:51, Ami Fischman wrote: > Removing myself as reviewer to remove this from ...
2 years, 11 months ago (2014-05-22 17:33:42 UTC) #23
haltonhuo
2 years, 11 months ago (2014-05-23 02:03:44 UTC) #24
On 2014/05/22 17:33:42, Jorge Lucangeli Obes wrote:
> On 2013/10/31 21:28:51, Ami Fischman wrote:
> > Removing myself as reviewer to remove this from my CL list.
> 
> Removing myself as a reviewer. Not sure why this CL keeps getting updated.

We use this patch for our linux based projects, keep update to ensure others can
use this patch.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46